Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom: bump opentelemetry-extension 1.10.0 #2464

Closed
wants to merge 3 commits into from

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 10, 2022

What does this PR do?

Bump dependency to pick up the latest updates for the integration in the CI with the opentelemetry extension for the maven builds.

Features

opentelemetry-maven-extension 1.10.0

opentelemetry-maven-extension 1.9.0

@v1v v1v added the automation Tests & automation that help build & maintain the project label Feb 10, 2022
@v1v v1v requested review from cyrille-leclerc and a team February 10, 2022 10:27
@v1v v1v self-assigned this Feb 10, 2022
@v1v v1v changed the title pom: bump opentelemetry-extension pom: bump opentelemetry-extension 1.10.0 Feb 10, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Feb 10, 2022

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-01T14:39:27.860+0000

  • Duration: 45 min 17 sec

Test stats 🧪

Test Results
Failed 2
Passed 2991
Skipped 36
Total 3029

Test errors 2

Expand to view the tests failures

Builds / Tests / Non-Application Server integration tests / testVersion{String, boolean}[12] – co.elastic.apm.agent.resttemplate.SpringRestTemplateVersionsIT
    Expand to view the error details

     
    Expecting value to be true but was false 
    

    Expand to view the stacktrace

     org.opentest4j.AssertionFailedError: 
    
    Expecting value to be true but was false
    	at co.elastic.apm.agent.resttemplate.SpringRestTemplateVersionsIT.testVersion(SpringRestTemplateVersionsIT.java:96)
     
    

Builds / Tests / Application Server integration tests / testAllScenarios[JBoss jboss-eap-7/eap70-openshift] – co.elastic.apm.servlet.JBossIT
    Expand to view the error details

     Container startup failed 
    

    Expand to view the stacktrace

     org.testcontainers.containers.ContainerLaunchException: Container startup failed
    	at co.elastic.apm.servlet.JBossIT.<init>(JBossIT.java:37)
    Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=registry.access.redhat.com/jboss-eap-7/eap70-openshift:latest, imagePullPolicy=DefaultPullPolicy())
    	at co.elastic.apm.servlet.JBossIT.<init>(JBossIT.java:37)
    Caused by: org.testcontainers.containers.ContainerFetchException: Failed to pull image: registry.access.redhat.com/jboss-eap-7/eap70-openshift:latest
    	at co.elastic.apm.servlet.JBossIT.<init>(JBossIT.java:37)
    Caused by: com.github.dockerjava.api.exception.InternalServerErrorException: 
    Status 500: {"message":"unsupported: Not Found, or unsupported. V2 schema 1 manifest digest are no longer supported for image pulls. Use the equivalent schema 2 manifest digest instead. For more information see https://access.redhat.com/articles/6138332"}
    
     
    

Steps errors 1

Expand to view the steps failures

Shell Script
  • Took 29 min 32 sec . View more details here
  • Description: ./mvnw -q -P ci-non-application-server-integration-tests verify

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v
Copy link
Member Author

v1v commented Feb 10, 2022

/test

@v1v
Copy link
Member Author

v1v commented Feb 10, 2022

@cyrille-leclerc , are you aware of any breaking changes between 1.7 and 1.11? I don't see any traces but there are traces with 1.7, for instance:

  • The latest build in the main branch produced traces, see here
  • But the ones for this PR, it's empty -> see here

I can bump from 1.7 to 1.9 to bisect what's the reason

@cyrille-leclerc
Copy link

Please bump the otel collector

@v1v
Copy link
Member Author

v1v commented Mar 7, 2022

/test

1 similar comment
@v1v
Copy link
Member Author

v1v commented Mar 15, 2022

/test

@SylvainJuge
Copy link
Member

@v1v do you think we can merge this ? The test failures are not related and seems related to flaky tests.

@v1v
Copy link
Member Author

v1v commented Mar 28, 2022

No yet, somehow I don't see the traces in the OTEL backend, so I might need to contact the infra team as somehow the OTEL collector might still point to an old version

@v1v
Copy link
Member Author

v1v commented Apr 27, 2022

/test

@SylvainJuge
Copy link
Member

The latest version is 1.17.0 (https://github.com/open-telemetry/opentelemetry-java-contrib/releases/tag/v1.17.0), should we update this PR to this latest version or conservatively keep it to 1.10.0 ?

@v1v
Copy link
Member Author

v1v commented Aug 25, 2022

We might close it, the existing infrastructure requires further upgrades and syncup with the CI systems team, so a bit tedious atm

@SylvainJuge
Copy link
Member

I see, I don't mind keeping this one around until we can make progress here, it is up to what you prefer. I have marked it to the blocked to reflect that.
Do you have another issue to track all the things that needs to be resolved before we can do the upgrade ?

@v1v
Copy link
Member Author

v1v commented Aug 26, 2022

Do you have another issue to track all the things that needs to be resolved before we can do the upgrade ?

Within this PR there are some issues linked to this one, since those issues are coming from private repositories, I don't want to add anything to avoid any misleading. Those issues should be shown if you have access to those private repositories, which I think you have access.

Let's keep it open for a bit

@eyalkoren
Copy link
Contributor

Let's keep it open for a bit

@v1v @SylvainJuge what do you say we close this PR as a celebration for its 1-year anniversary? 👶

@v1v v1v closed this Feb 5, 2023
@v1v
Copy link
Member Author

v1v commented Feb 5, 2023

For more context, I closed this as we are moving away from Jenkins, and I could not get any further details about the existing infra in place...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java automation Tests & automation that help build & maintain the project blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants