Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casting to parent Buffer #401

Merged

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Dec 27, 2018

Fixing #400

@codecov-io
Copy link

codecov-io commented Dec 27, 2018

Codecov Report

Merging #401 into master will decrease coverage by 0.47%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #401      +/-   ##
============================================
- Coverage     72.49%   72.01%   -0.48%     
+ Complexity     1325     1265      -60     
============================================
  Files           141      140       -1     
  Lines          5213     4864     -349     
  Branches        554      495      -59     
============================================
- Hits           3779     3503     -276     
+ Misses         1210     1138      -72     
+ Partials        224      223       -1
Impacted Files Coverage Δ Complexity Δ
...java/co/elastic/apm/agent/impl/transaction/Db.java 59.45% <0%> (ø) 12 <0> (ø) ⬇️
.../agent/plugin/api/AbstractSpanInstrumentation.java 53.19% <0%> (-11.27%) 3% <0%> (-7%)
...java/co/elastic/apm/agent/bci/ElasticApmAgent.java 72.18% <0%> (-1.74%) 19% <0%> (-3%)
...astic/apm/agent/impl/transaction/TraceContext.java 92.21% <0%> (-1.06%) 56% <0%> (-44%)
...bci/bytebuddy/FailSafeDeclaredMethodsCompiler.java
...agent/plugin/api/ElasticApmApiInstrumentation.java 52% <0%> (+3.47%) 3% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863822f...2a5b273. Read the comment docs.

@eyalkoren eyalkoren merged commit 2a28fe7 into elastic:master Dec 27, 2018
@eyalkoren eyalkoren self-assigned this Dec 27, 2018
@eyalkoren eyalkoren deleted the fixing-nio-buffer-versioning-issue branch January 9, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants