Skip to content

Commit

Permalink
ci: lock on older mssql/server Docker image to avoid healthcheck brea…
Browse files Browse the repository at this point in the history
…kage (#4148)

The latest mcr.microsoft.com/mssql/server release (CU14) moves the sqlcmd
install location, breaking our healthcheck. Just updating the path hits
a different error. As a workaround, lets pin to the working mssql/server
docker image for CI.
Note that this docker compose file is used for TAV tests.
I'm not sure if hte mssql/server image used by GH Actions' mssql
'service' will be affected at some point as well.

Closes: #4147
  • Loading branch information
trentm committed Jul 24, 2024
1 parent ab6f3a0 commit 1a326b9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .ci/docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ services:
retries: 30

mssql:
image: mcr.microsoft.com/mssql/server
# Cumulative update 14 (CU14), released 2024-07-23, breaks the healthcheck.
# See https://github.com/elastic/apm-agent-nodejs/issues/4147
image: mcr.microsoft.com/mssql/server:2022-CU13-ubuntu-22.04
platform: linux/amd64
environment:
- ACCEPT_EULA=Y
Expand Down
4 changes: 3 additions & 1 deletion test/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ services:
retries: 30

mssql:
image: mcr.microsoft.com/mssql/server
# Cumulative update 14 (CU14), released 2024-07-23, breaks the healthcheck.
# See https://github.com/elastic/apm-agent-nodejs/issues/4147
image: mcr.microsoft.com/mssql/server:2022-CU13-ubuntu-22.04
platform: linux/amd64
environment:
- ACCEPT_EULA=Y
Expand Down

0 comments on commit 1a326b9

Please sign in to comment.