Skip to content

Commit

Permalink
fix(tests): fix hang in ioredis test
Browse files Browse the repository at this point in the history
[email protected] includes a bug when using `redis.quit()` that can leave
a setInterval uncleared. See redis/ioredis#1215.

Fixes #1838
  • Loading branch information
trentm committed Oct 26, 2020
1 parent 4fe301d commit 8da092a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/instrumentation/modules/ioredis.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ test('not nested', function (t) {
t.strictEqual(calls, 3)

agent.endTransaction()
redis.quit()
redis.disconnect()
agent.flush()
})
})
Expand Down Expand Up @@ -91,7 +91,7 @@ test('nested', function (t) {
t.strictEqual(calls, 2)

agent.endTransaction()
redis.quit()
redis.disconnect()
agent.flush()
})
})
Expand Down Expand Up @@ -123,7 +123,7 @@ test('rejections_handled', function (t) {
redis.get('a', function (err, result) {
t.ok(err)
trans.end()
redis.quit()
redis.disconnect()
agent.flush()
}) // wrong type, should reject
})
Expand Down

0 comments on commit 8da092a

Please sign in to comment.