Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logger performance by removing unnecessary line prefix generation #1068

Closed
intuibase opened this issue Sep 25, 2023 · 0 comments · Fixed by #1069
Closed

Improve logger performance by removing unnecessary line prefix generation #1068

intuibase opened this issue Sep 25, 2023 · 0 comments · Fixed by #1069
Assignees
@intuibase
Labels
agent-php
Milestone
8.11

Comments

@intuibase
Copy link
Contributor

Optimization involves generating a prefix for each log line only if the 'display' criteria are met. If the log level is too low or the log is disabled - the function will not be executed.

This will save on fetching local time, process id and on generating strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@intuibase intuibase

Labels
agent-php
Projects
APM-Agents (OLD)
Status: Done
Milestone
8.11
Development

Successfully merging a pull request may close this issue.

Optimize log line prefix generation based on display criteria (#1068) intuibase/apm-agent-php
1 participant
@intuibase