Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: use reusable actions #1058

Merged
merged 1 commit into from
Sep 11, 2023
Merged

action: use reusable actions #1058

merged 1 commit into from
Sep 11, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 11, 2023

Use reusable action so we can refactor the release pipeline and the CI pipeline and reuse them.

Notifies #1056

@v1v v1v self-assigned this Sep 11, 2023
Copy link
Contributor

@intuibase intuibase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool feature

@v1v
Copy link
Member Author

v1v commented Sep 11, 2023

build / build-agent-library (linux-x86-64) failed with the below error

 xz_utils/5.4.2: Downloaded recipe revision 0
  ERROR: Conflict in libunwind/1.6.2:
      'libunwind/1.6.2' requires 'zlib/1.2.13' while 'libcurl/8.0.1' requires 'zlib/1.3'.
      To fix this conflict you need to override the package 'zlib' in your root package.
  CMake Error at building/cmake/conan.cmake:552 (message):
    Conan install failed='1'
  Call Stack (most recent call first):
    building/cmake/conan.cmake:894 (old_conan_cmake_install)
    CMakeLists.txt:104 (conan_cmake_run)

@intuibase have you seen that error in the past?

@intuibase
Copy link
Contributor

@intuibase have you seen that error in the past?

No. I will take a look and try it locally.

@v1v
Copy link
Member Author

v1v commented Sep 11, 2023

I will take a look and try it locally.

I rerun it and it works now -> https://github.com/elastic/apm-agent-php/actions/runs/6145325680/job/16672920109?pr=1058 or at least is moving further

@v1v v1v marked this pull request as ready for review September 11, 2023 12:28
@v1v v1v requested a review from a team September 11, 2023 12:28
@v1v v1v merged commit 86e54c2 into main Sep 11, 2023
151 checks passed
@v1v v1v mentioned this pull request Sep 11, 2023
v1v added a commit that referenced this pull request Sep 11, 2023
…kins

* upstream/main:
  action: use reusable actions (#1058)
  Modified class and method separator to be always '::' (1054) (#1055)
@intuibase
Copy link
Contributor

just to document, zlib conflict solved in #1060

@v1v v1v deleted the feature/refactor-ci-actions branch September 11, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants