Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: support packages for signed/unsigned and fix release checksum validation #1062

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 12, 2023

Fixing some issues that have been discovered when trying the release v1.10.0:

  • Support test-packages with the signed artifacts in addition to the unsigned artifacts.
  • Fix typo in Verify draft release
  • Remove unrequired echo "RELEASE_ID=$(make -f .ci/Makefile get-draft-release)" >> $GITHUB_ENV
  • Notify when the release has started

Test

I created a test branch based on this PR but using a different slack channel and skipped the release steps

Expand to view diff

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index fa85af04..f4bc8eb5 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -6,7 +6,6 @@ permissions:
 
 on:
   push:
-    tags: [ "v[0-9]+*" ]
 
 env:
   BUILD_PACKAGES: build/packages
@@ -21,7 +20,7 @@ jobs:
           url: ${{ secrets.VAULT_ADDR }}
           roleId: ${{ secrets.VAULT_ROLE_ID }}
           secretId: ${{ secrets.VAULT_SECRET_ID }}
-          channel: "#apm-agent-php"
+          channel: "#on-week-oblt-productivity"
           message: |
             :runner: [${{ github.repository }}] Release *${{ github.ref_name }}* has been triggered : (<${{ steps.buildkite.outputs.build }}|here> for further details)
 
@@ -126,13 +125,13 @@ jobs:
           PACKAGE_FILE: "signed-artifacts.zip"
 
       - name: Create draft release
-        run: make -f .ci/Makefile draft-release
+        run: echo "make -f .ci/Makefile draft-release"
 
       - name: Verify draft release
-        run: ORIGINAL_PACKAGES_LOCATION=${{ env.BUILD_PACKAGES }} make -f .ci/Makefile download-verify
+        run: echo "ORIGINAL_PACKAGES_LOCATION=${{ env.BUILD_PACKAGES }} make -f .ci/Makefile download-verify"
 
       - name: Publish release
-        run: make -f .ci/Makefile github-release-ready
+        run: echo "make -f .ci/Makefile github-release-ready"
 
   notify:
     if: always()
@@ -155,5 +154,5 @@ jobs:
           vaultUrl: ${{ secrets.VAULT_ADDR }}
           vaultRoleId: ${{ secrets.VAULT_ROLE_ID }}
           vaultSecretId: ${{ secrets.VAULT_SECRET_ID }}
-          slackChannel: "#apm-agent-php"
+          slackChannel: "#on-week-oblt-productivity"
           message: "[${{ github.repository }}] Release (<${{ github.server_url }}/${{ github.repository }}/releases/tag/${{ github.ref_name }}|${{ github.ref_name }}>)"

This build is the one verifying this PR will work as expected.

A slack message is created like the below one (bear in mind, it uses the ref, in this case the test branch, but it will be a tag when merged)

image

@v1v v1v requested review from a team September 12, 2023 16:48
@v1v v1v self-assigned this Sep 12, 2023
intuibase
intuibase previously approved these changes Sep 12, 2023
reakaleek
reakaleek previously approved these changes Sep 12, 2023
.github/workflows/test-packages.yml Outdated Show resolved Hide resolved
@v1v v1v dismissed stale reviews from reakaleek and intuibase via 7c4d621 September 13, 2023 07:36
@v1v v1v merged commit 1c6f09c into main Sep 13, 2023
146 checks passed
@v1v v1v deleted the fix/release-to-use-signed-artifacts branch October 3, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants