-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packaging] support multiple PHP API #121
Conversation
86b26c2
to
34870cb
Compare
34870cb
to
9230888
Compare
.ci/Jenkinsfile
Outdated
unstash 'generate-7.2' | ||
unstash 'generate-7.3' | ||
unstash 'generate-7.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say this is not ideal, although we could potentially use something else to simplify where the generated so files are stored
01d82fa
to
101901c
Compare
RUN apt-get -qq update \ | ||
&& apt-get -qq install -y procps --no-install-recommends \ | ||
&& apt-get -qq install -y git procps zlib1g-dev libzip-dev unzip --no-install-recommends \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required dependencies when running composer install
without any cached dependencies
## sh: git: command not found | ||
# the zip extension and unzip command are both missing, skipping. | ||
RUN yum update -y \ | ||
&& yum install -y git unzip \ | ||
&& yum clean all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* upstream/master: Add ENVIRONMENT configuration option Change composer installation in docker (elastic#128) Add tests/APM_Agents_shared directory [packaging] support multiple PHP API (elastic#121) [Packaging] restore php.ini if something bad happened (elastic#116) [CI] Cosmetic changes in the stage names (elastic#115)
What
install
make goal has been deleted since it's already done when runningmake -C packaging deb-install
clean
make goal to tear down the generated packages folder.composer install
in the docker containers.Tasks
Issues
Closes #113
Closes #114
Tests
How to test it locally?
Improvements
matrix
approach