Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminaries and ini tidy up #6

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Preliminaries and ini tidy up #6

merged 2 commits into from
Oct 14, 2019

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Oct 14, 2019

  • renamed the php.ini to elasticapm.ini
  • added comments to the ini file

@philkra philkra requested a review from ezimuel October 14, 2019 14:20
ezimuel
ezimuel approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@philkra philkra merged commit 45767b6 into master Oct 14, 2019
@philkra philkra deleted the preliminaries_and_ini_tidy_up branch October 14, 2019 14:27
@keeshoekzema keeshoekzema mentioned this pull request Apr 21, 2023
Closed
@Yourcloud-host Yourcloud-host mentioned this pull request Jun 12, 2023
Closed
@Arya-Aniket Arya-Aniket mentioned this pull request Feb 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimuel ezimuel ezimuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philkra @ezimuel