Return the context in ProcessBatch #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before we go ahead with this, can you show how it would be used with a code example? Is it possible to do this by wrapping, rather than chaining? |
|
You are right, using a wrapper processor is a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, processors can't communicate with each other, which is something I need to do to start doing tracing within them.
By returning a context after ProcessBatch, the processor can change the context and return a new one, which will be used by every underlying processor.
With that, processors will be able to communicate with each other, and more specifically, one will be able to start a span, and another one to finish it (and possibly every other one, to retrieve the span in context and add attributes).