Require only one of exception.{type,message} for log exceptions #182
Conversation
otel semconv require that at lease one field between exception.message or exception.type to be present on an application exception. To ensure we respect them we default on adding exception.type only if has a value and defaulting exception.message to a constant string when empty and no exception.type is present.
Trigger exception creation for any log message with either message or type. This aligns to otel semconv requirements for exceptions.
| exceptionError.Exception.Type = exceptionType | ||
| if exceptionType != "" { | ||
| exceptionError.Exception.Type = exceptionType | ||
| } |
There was a problem hiding this comment.
question: weren't we already doing this ? exceptionType is a string so the zero value is the empty string. Am I missing something ?
There was a problem hiding this comment.
Before this PR exceptionType always has a value as we check presence of both exceptionMessage and exceptionType before calling this function.
With the change in the condition (from and to or) it is now possible for exceptionType to be an empty value. As the spec says that "at least one is mandatory" and we were already forcing exceptionMessage to a const when empty, I added this guard clause to not set exceptionError.Exception.Type to an empty string value.
|
Tested this PR comparing both before and after. I can see the "exception" was missing from the logs if one of the two field was empty. Now, it's mapped correctly. |
Change OTLP log input to identify as exception any log that has an exception message or type attribute.
Before this change only logs with both attributes where considered as exceptions.
Closes #176