Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky TestConsumeMetricsWithOTelRemapper #312

Merged
merged 2 commits into from
Jul 4, 2024

Fix eventsMatch

387e675
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix flaky TestConsumeMetricsWithOTelRemapper #312

Fix eventsMatch
387e675
Select commit
Loading
Failed to load commit list.
GitHub Actions / benchdiff-result succeeded Jul 4, 2024 in 0s

Benchdiff Results

Benchmark Command: go test ./... -run ^ -bench . -count 5 -benchtime 100ms -cpu 1,2 -benchmem

HEAD sha: 387e675

Base sha: e5d0335

Degraded: false

Details

pkg: github.com/elastic/apm-data/codec
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
Encode/format=json 26704.8 0% 26297.4 0% -1.53% (p=0.016 n=4+5)
Encode/format=json-2 14426.6 6% 14612.5 2% ~ (p=0.286 n=5+4)
Encode/format=vtproto 4688.8 1% 4744.2 0% ~ (p=0.151 n=5+5)
Encode/format=vtproto-2 3079.6 13% 2612.6 2% -15.16% (p=0.008 n=5+5)
Decode/format=json 129280 2% 144431 28% ~ (p=0.690 n=5+5)
Decode/format=json-2 70153.2 28% 68621.5 4% ~ (p=0.286 n=5+4)
Decode/format=vtproto 24277.8 24% 20591.6 2% -15.18% (p=0.032 n=5+5)
Decode/format=vtproto-2 13172.4 4% 12498 4% -5.12% (p=0.032 n=5+5)
name old bytes/op (bytes/op) ± new bytes/op (bytes/op) ± delta ±
Encode/format=json 6564 0% 6564 0% ~ (all equal)
Encode/format=json-2 6564 0% 6564 0% ~ (all equal)
Encode/format=vtproto 2775 0% 2775 0% ~ (all equal)
Encode/format=vtproto-2 2775 0% 2775 0% ~ (all equal)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
Encode/format=json 7752 0% 7752 0% ~ (all equal)
Encode/format=json-2 7753 0% 7753 0% ~ (all equal)
Encode/format=vtproto 3072 0% 3072 0% ~ (all equal)
Encode/format=vtproto-2 3072 0% 3072 0% ~ (all equal)
Decode/format=json 14504 0% 14504 0% ~ (all equal)
Decode/format=json-2 14504 0% 14504 0% ~ (all equal)
Decode/format=vtproto 12976 0% 12976 0% ~ (all equal)
Decode/format=vtproto-2 13013.5 0% 13014 0% ~ (p=0.619 n=4+5)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
Encode/format=json 30 0% 30 0% ~ (all equal)
Encode/format=json-2 30 0% 30 0% ~ (all equal)
Encode/format=vtproto 1 0% 1 0% ~ (all equal)
Encode/format=vtproto-2 1 0% 1 0% ~ (all equal)
Decode/format=json 397 0% 397 0% ~ (all equal)
Decode/format=json-2 397 0% 397 0% ~ (all equal)
Decode/format=vtproto 348 0% 348 0% ~ (all equal)
Decode/format=vtproto-2 348 0% 348 0% ~ (all equal)

pkg: github.com/elastic/apm-data/input/elasticapm/internal/decoder
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
NDStreamDecoder 277.38 4% 275.56 3% ~ (p=0.571 n=5+5)
NDStreamDecoder-2 157.14 2% 154.3 2% ~ (p=0.087 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
NDStreamDecoder 72 0% 72 0% ~ (all equal)
NDStreamDecoder-2 72 0% 72 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
NDStreamDecoder 4 0% 4 0% ~ (all equal)
NDStreamDecoder-2 4 0% 4 0% ~ (all equal)

pkg: github.com/elastic/apm-data/model/modeljson
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
APMEventToJSON/to-json 14158.6 8% 14016.2 9% ~ (p=0.690 n=5+5)
APMEventToJSON/to-json-2 12688 4% 12273.4 2% ~ (p=0.056 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
APMEventToJSON/to-json 2472 0% 2472 0% ~ (all equal)
APMEventToJSON/to-json-2 2472 0% 2472 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
APMEventToJSON/to-json 37 0% 37 0% ~ (all equal)
APMEventToJSON/to-json-2 37 0% 37 0% ~ (all equal)
View more details on GitHub Actions