Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix host.ip 0.0.0.0 treated as invalid #323

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

carsonip
Copy link
Member

host.ip is parsed from resource attribute ip when resource attribute opencensus.exporterversion has prefix Jaeger. This PR fixes the incorrect handling of value 0.0.0.0 of this field.

@carsonip carsonip requested a review from a team as a code owner July 17, 2024 13:57
@obltmachine obltmachine added the safe-to-test Changes are safe to run in the CI label Jul 17, 2024
kruskall
kruskall previously approved these changes Jul 17, 2024
@carsonip carsonip merged commit 933c168 into elastic:main Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Changes are safe to run in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants