feat: normalize interface before converting to structpb #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
structpb conversion could fail if the value is not supported. To avoid an error and losing data we normalize the value to make sure we are dealing with supported types.
dmathieu
approved these changes
Jun 22, 2023
endorama
added a commit
to endorama/apm-data
that referenced
this pull request
Jun 23, 2023
structpb conversion could fail if the value is not supported. To avoid an error and losing data we normalize the value to make sure we are dealing with supported types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
structpb conversion could fail if the value is not supported. To avoid an error and losing data we normalize the value to make sure we are dealing with supported types.