Add received to Event
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruskall
requested changes
Jun 23, 2023
kruskall
approved these changes
Jun 23, 2023
|
@kruskall No worries and thanks for catching the bad test! |
Signed-off-by: Edoardo Tenani <[email protected]>
Signed-off-by: Edoardo Tenani <[email protected]>
`Event.Received` weren't really tested by the current tests, due to the use of `cmpopts.IgnoreUnexported`. I wrongly assumed that with that option only unexported fields would be ignored but in this case the result was a complete lack of verification on the time value. This commimt removes `IgnoreUnexported` and add a custom comparer to ensure time correspond. Co-authored-by: kruskall <[email protected]>
I'm using go 1.20 locally for testing while CI is using go 1.19.10. This version does not have Time.Compare.
endorama
force-pushed
the
event-received
branch
2 times, most recently
from
148bcc8
to
808563b
Compare
This was referenced Jun 27, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of data ingestion one interesting element we want to keep track of is when a certain event has been received by the ingestion backend.
This timestamp is not user-controlled like
@timestampand can guarantee us a certain timestamp for event reception, the step before ingestion (which is registered asevent.ingested).This PR adds the
event.receivedfield to protobuf Event andmodeljson.Event.This field value will be empty in
modeljson.Eventif it's not set in protobufEvent.Tests have been adjusted to account for the additional field.