Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clonevt methods #87

Merged
merged 4 commits into from
Jun 27, 2023
Merged

feat: add clonevt methods #87

merged 4 commits into from
Jun 27, 2023

Commits on Jun 27, 2023

  1. feat: add clonevt feature to modelpb generation

    @kruskall
    kruskall committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e89e00e View commit details
    Browse the repository at this point in the history

  2. feat: generate clonevt methods

    @kruskall
    kruskall committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    be5cb0e View commit details
    Browse the repository at this point in the history

  3. feat: use clonevt methods in decoders 

    Benchmark showed a 50% decrease in cpu time when comparing the two
clone methods:

               │  before.txt  │              after.txt              │
               │    sec/op    │   sec/op     vs base                │
Clone/clone-20   15.099µ ± 6%   7.326µ ± 5%  -51.48% (p=0.000 n=10)

               │  before.txt  │              after.txt              │
               │     B/op     │     B/op      vs base               │
Clone/clone-20   12.77Ki ± 0%   12.20Ki ± 0%  -4.46% (p=0.000 n=10)

               │ before.txt │             after.txt             │
               │ allocs/op  │ allocs/op   vs base               │
Clone/clone-20   172.0 ± 0%   163.0 ± 0%  -5.23% (p=0.000 n=10)

Additionally, since clone already performs a deep copy, we can avoid
cloning the event twice.
    @kruskall
    kruskall committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2505e71 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/clone-vt

    @kruskall
    kruskall committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    4ee3ff4 View commit details
    Browse the repository at this point in the history