Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make all command #99

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Add make all command #99

merged 2 commits into from
Jul 5, 2023

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 4, 2023

There are a lot of different make commands in this project, and as I was updating the proto definitions, I ended up having to use many of them (generate-modelpb, update-licenses, fmt for a proto update).
So this make all command is a utility tool to make it easier to regenerate and clean up everything.

@dmathieu dmathieu requested a review from a team July 4, 2023 10:23
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Maybe later we can add some finer-grained dependencies between tasks, so running "make generate-modelpb" would also add license headers and format the code, without also running fieldalignment and gomodtidy. This is good enough for now though.

@dmathieu dmathieu merged commit 8bc2963 into elastic:main Jul 5, 2023
2 checks passed
@dmathieu dmathieu deleted the make-all branch July 5, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants