Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Add option and script to inject a custom apm-server into Elastic Agent #1030

Closed
wants to merge 7 commits into from

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Jan 14, 2021

What does this PR do?

This should enable us to run elastic-agent with an arbitrary apm-server binary.

Why is it important?

To run tests in pull requests with elastic agent and the apm-server from the current branch

Depends on #1016

@apmmachine
Copy link
Collaborator

apmmachine commented Jan 14, 2021

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-07T15:37:41.304+0000

  • Duration: 5 min 47 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jalvz jalvz marked this pull request as ready for review January 15, 2021 12:53
Co-authored-by: Ivan Fernandez Calvo <[email protected]>
Co-authored-by: Ivan Fernandez Calvo <[email protected]>
@kuisathaverat
Copy link
Contributor

this replaces the binary in the Elastic Agent container, if there is an APM Server running, would it restarted to pick the new binary?

@jalvz
Copy link
Contributor Author

jalvz commented Jan 19, 2021

this replaces the binary in the Elastic Agent container, if there is an APM Server running, would it restarted to pick the new binary?

good question 😎

I didn't get to that part yet, I was waiting to have 1016 merged to see how it all plays together.
I'm going to move this back to draft in the meanwhile

@jalvz jalvz marked this pull request as draft January 19, 2021 09:50
@kuisathaverat
Copy link
Contributor

I'd said that is easy to use the same approach we have for all the containers, build a derivated Docker container. In this particular case, a Docker container FROM the Elastic Agent container, then we add similar logic we have for opbeans to compile the APM Server and add it to the Elastic Agent Docker image.

@graphaelli graphaelli closed this Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants