Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the attribute references #1496

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

kuisathaverat
Copy link
Contributor

What does this PR do?

  • update the attribute references
    • prepare for send metrics

Why is it important?

To use the ECS for the attributes is key to having the same experience across test frameworks. Metrics also are a useful data to collect.

@kuisathaverat kuisathaverat added the Team:Automation Label for the Observability productivity team label Jan 13, 2022
@kuisathaverat kuisathaverat requested a review from a team January 13, 2022 09:37
@kuisathaverat kuisathaverat self-assigned this Jan 13, 2022
@@ -18,6 +19,12 @@
from opentelemetry.trace.propagation.tracecontext import TraceContextTextMapPropagator
from opentelemetry.trace.status import Status, StatusCode

# from opentelemetry import metrics
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the metrics are available on >1.7.0, but we cannot update yet due to that version has a bug on the headers, this bug breaks the authentication with headers

@apmmachine
Copy link
Contributor

apmmachine commented Jan 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-31T09:28:56.317+0000

  • Duration: 13 min 30 sec

  • Commit: 71d652a

Test stats 🧪

Test Results
Failed 0
Passed 1335
Skipped 2
Total 1337

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run infra tests : Run the test-infra test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kuisathaverat kuisathaverat marked this pull request as ready for review January 31, 2022 09:21
@kuisathaverat kuisathaverat requested a review from a team as a code owner January 31, 2022 09:21
@kuisathaverat kuisathaverat merged commit f59ee3a into elastic:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants