Fix approvals

elastic · Feb 10, 2021 · 5fb860f · 5fb860f
1 parent 78207c3
commit 5fb860f
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 22 deletions.
diff --git a/systemtest/approvals/TestOTLPGRPC.approved.json b/systemtest/approvals/TestOTLPGRPC.approved.json
@@ -26,6 +26,9 @@
                 "name": "transaction"
             },
             "service": {
+                "framework": {
+                    "name": "systemtest"
+                },
                 "language": {
                     "name": "unknown"
                 },

diff --git a/testdata/jaeger/batch_0.approved.json b/testdata/jaeger/batch_0.approved.json
@@ -8,7 +8,7 @@
                 "version": "2.20.1"
             },
             "event": {
-                "outcome": "success"
+                "outcome": "unknown"
             },
             "host": {
                 "hostname": "host01",
@@ -48,7 +48,6 @@
                 },
                 "id": "7be2fd98d0973be3",
                 "name": "Driver::findNearest",
-                "result": "Success",
                 "sampled": true,
                 "type": "custom"
             }

diff --git a/testdata/jaeger/batch_1.approved.json b/testdata/jaeger/batch_1.approved.json
@@ -40,7 +40,7 @@
                 },
                 "id": "6e09e8bcefd6b828",
                 "name": "FindDriverIDs",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827704954062
@@ -57,7 +57,7 @@
                 "version": "2.20.1"
             },
             "event": {
-                "outcome": "unknown"
+                "outcome": "failure"
             },
             "host": {
                 "hostname": "host01",
@@ -89,7 +89,7 @@
                 },
                 "id": "333295bfb438ea03",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827704973809
@@ -138,7 +138,7 @@
                 },
                 "id": "627c37a97e475c2f",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705007578
@@ -187,7 +187,7 @@
                 },
                 "id": "7bd7663d39c5a847",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705016845
@@ -236,7 +236,7 @@
                 },
                 "id": "6b4051dd2a5e2366",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705029415
@@ -285,7 +285,7 @@
                 },
                 "id": "6df97a86b9b3451b",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705040082
@@ -302,7 +302,7 @@
                 "version": "2.20.1"
             },
             "event": {
-                "outcome": "unknown"
+                "outcome": "failure"
             },
             "host": {
                 "hostname": "host01",
@@ -334,7 +334,7 @@
                 },
                 "id": "614811d6c498bfb0",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705054046
@@ -383,7 +383,7 @@
                 },
                 "id": "231604559da84d61",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705089459
@@ -432,7 +432,7 @@
                 },
                 "id": "61f7ecf24d13c36a",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705101278
@@ -481,7 +481,7 @@
                 },
                 "id": "2ef335bad24accc2",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705113531
@@ -530,7 +530,7 @@
                 },
                 "id": "38ec645e7201224d",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705125567
@@ -547,7 +547,7 @@
                 "version": "2.20.1"
             },
             "event": {
-                "outcome": "unknown"
+                "outcome": "failure"
             },
             "host": {
                 "hostname": "host01",
@@ -579,7 +579,7 @@
                 },
                 "id": "0242ee3774d9eab1",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705132896
@@ -628,7 +628,7 @@
                 },
                 "id": "6a63d1e81cfc7d95",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705172618
@@ -677,7 +677,7 @@
                 },
                 "id": "2b4c28f02b272f17",
                 "name": "GetDriver",
-                "type": "custom"
+                "type": "app"
             },
             "timestamp": {
                 "us": 1576827705186670

diff --git a/tests/system/jaeger_batch_0_auth_tag_removed.approved.json b/tests/system/jaeger_batch_0_auth_tag_removed.approved.json
@@ -59,7 +59,6 @@
             },
             "id": "7be2fd98d0973be3",
             "name": "Driver::findNearest",
-            "result": "Success",
             "sampled": true,
             "type": "custom"
         }

diff --git a/tests/system/jaeger_batch_0_authorization.approved.json b/tests/system/jaeger_batch_0_authorization.approved.json
@@ -59,7 +59,6 @@
             },
             "id": "7be2fd98d0973be3",
             "name": "Driver::findNearest",
-            "result": "Success",
             "sampled": true,
             "type": "custom"
         }

diff --git a/tests/system/jaeger_span.approved.json b/tests/system/jaeger_span.approved.json
@@ -55,7 +55,6 @@
             },
             "id": "5025e08c7fef6542",
             "name": "test_span",
-            "result": "Success",
             "sampled": true,
             "type": "custom"
         }