Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jaeger] How to support sampling #3011

Closed
simitt opened this issue Dec 5, 2019 · 3 comments · Fixed by #3722
Closed

[Jaeger] How to support sampling #3011

simitt opened this issue Dec 5, 2019 · 3 comments · Fixed by #3722

Comments

@simitt
Copy link
Contributor

simitt commented Dec 5, 2019

When using probabilistic sampling Jaeger only sends sampled spans. Elastic APM UI currently requires a 100% of the transaction events. Elastic APM agent only sample spans.
Investigate how to solve sampling with Jaeger integration.

Part of #2886

UPDATE:
As probabilistic sampling support was added with #3487 this Issue now solely focuses on changes necessary to integrate Jaeger sampled traces into the APM app.

@jalvz
Copy link
Contributor

jalvz commented Feb 12, 2020

Has there been any thought / discussion about this already?

@axw
Copy link
Member

axw commented Feb 12, 2020

Copying this over from #2886 (comment):

[concept]: When using probabilistic sampling jaeger only sends sampled spans. Elastic APM requires a 100% of the transaction events and only samples spans. Investigate how to solve sampling with jaeger integration.

Outside of the context of Jaeger, there's been some discussion around relying on metrics so we don't need to send and store non-sampled transactions. This is elastic/apm#104.

If we were to do that, we could have the server aggregate metrics based on sampled Jaeger trace data. Jaeger sends up the sampling rate in effect at the time a trace is captured, so we can scale the count/total based on that.

@simitt
Copy link
Contributor Author

simitt commented Mar 16, 2020

As part of this Issue #3487 was created to add a gRPC Jaeger sampling endpoint. This issue does not consider any changes related to how APM UI calculates transactions per minutes, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants