Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jaeger] Add gRPC Sampling endpoint #3487

Closed
simitt opened this issue Mar 16, 2020 · 1 comment
Closed

[Jaeger] Add gRPC Sampling endpoint #3487

simitt opened this issue Mar 16, 2020 · 1 comment
Assignees
@simitt
Milestone
7.7

Comments

@simitt
Copy link
Contributor

simitt commented Mar 16, 2020 •
edited
Loading

As part of #3011 add the gRPC Jaeger sampling endpoint to the APM Server acting as Jaeger collector.

The endpoint will only support probabilistic sampling and should fetch the sampling rates from Kibana's agent configuration management.

By default the Jaeger sampling rate should be set to 100%.

Sampling in Jaeger tracing behaves different than Elastic APM sampling. Elastic APM currently always records 100% of transactions to allow a correct calculation of Requests per minute. Jaeger tracing only samples the configured percentage of transactions and spans, as there is no dedicated concept of transactions. If users configure a sampling rate smaller than 1, it will lead to incorrect values in the APM UI. We need to ensure this caveat is documented (cc @bmorelli25 ).

Why do we want to support sampling given this caveat?
Without the support of the sampling endpoint users that rely on sampling are excluding from using the Jaeger integration. With this change they can not depend on the Requests per Minute visualization, but can still make use of other Elastic APM features.
@simitt simitt added this to the 7.7 milestone Mar 16, 2020
@simitt simitt self-assigned this Mar 16, 2020
@simitt simitt mentioned this issue Mar 16, 2020
Closed
simitt added a commit to simitt/apm-server that referenced this issue Mar 16, 2020
@simitt
[Jaeger] Add gRPC sampling endpoint
29cdbab 
Support fetching Jaeger gRPC sampling strategy from APM
server. Only probabilistic sampling is supported. Sampling
rates are configured via Kibana agent config management.

implements elastic#3487
simitt added a commit to simitt/apm-server that referenced this issue Mar 16, 2020
@simitt
[Jaeger] Add gRPC sampling endpoint
ee24b29 
Support fetching Jaeger gRPC sampling strategy from APM
server. Only probabilistic sampling is supported. Sampling
rates are configured via Kibana agent config management.

implements elastic#3487
@simitt simitt mentioned this issue Mar 16, 2020
Merged
6 tasks
@bmorelli25 bmorelli25 mentioned this issue Mar 17, 2020
Merged
@bmorelli25
Copy link
Member

Thank you for the detailed write-up Silvia! Hope it's not too soon -- I've added documentation for this in #3493.

simitt added a commit that referenced this issue Mar 18, 2020
@simitt
[Jaeger] Add gRPC sampling endpoint (#3490)
98e0b1a 
Support fetching Jaeger gRPC sampling strategy from APM
server. Only probabilistic sampling is supported. Sampling
rates are configured via Kibana agent config management.

implements #3487
simitt added a commit to simitt/apm-server that referenced this issue Mar 18, 2020
@simitt
[Jaeger] Add gRPC sampling endpoint (elastic#3490)
16e102c 
Support fetching Jaeger gRPC sampling strategy from APM
server. Only probabilistic sampling is supported. Sampling
rates are configured via Kibana agent config management.

implements elastic#3487
@simitt simitt closed this as completed Mar 18, 2020
simitt added a commit that referenced this issue Mar 18, 2020
@simitt
[Jaeger] Add gRPC sampling endpoint (#3490) (#3497)
073dda6 
Support fetching Jaeger gRPC sampling strategy from APM
server. Only probabilistic sampling is supported. Sampling
rates are configured via Kibana agent config management.

implements #3487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simitt simitt

Labels
None yet
Projects
None yet
Milestone
7.7
Development

No branches or pull requests
3 participants
@graphaelli @simitt @bmorelli25