-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source mapping should not log warnings when service.version is unspecified #4119
Labels
Comments
Some kind of notification in the UI would likely be more visible to users. That could be done in a similar way, by identifying services without version defined. |
simitt
added a commit
to simitt/apm-server
that referenced
this issue
Sep 2, 2020
Remove unnecessary log line and change other from warning to debug level. fixes elastic#4119
simitt
added a commit
that referenced
this issue
Sep 3, 2020
Remove unnecessary log line and change other from warning to debug level. fixes #4119
simitt
added a commit
to simitt/apm-server
that referenced
this issue
Sep 3, 2020
Remove unnecessary log line and change other from warning to debug level. fixes elastic#4119
simitt
added a commit
that referenced
this issue
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For RUM spans and errors, we will log a warning for stack traces if
service.version
is undefined and source mapping is enabled:apm-server/model/stacktrace.go
Line 62 in acd41cc
Source mapping is enabled by default when RUM is enabled. Source mapping isn't necessarily expected by users, so we should not be logging warnings.
Assuming we will move source mapping entirely out of APM Server (#3606) then we may as well remove the logging now.
The text was updated successfully, but these errors were encountered: