Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source mapping should not log warnings when service.version is unspecified #4119

Closed
axw opened this issue Aug 31, 2020 · 1 comment · Fixed by #4132
Closed

Source mapping should not log warnings when service.version is unspecified #4119

axw opened this issue Aug 31, 2020 · 1 comment · Fixed by #4132
Assignees
Labels

Comments

@axw
Copy link
Member

axw commented Aug 31, 2020

For RUM spans and errors, we will log a warning for stack traces if service.version is undefined and source mapping is enabled:

logp.NewLogger(logs.Stacktrace).Warn(msgServiceInvalidForSourcemapping)

Source mapping is enabled by default when RUM is enabled. Source mapping isn't necessarily expected by users, so we should not be logging warnings.

Assuming we will move source mapping entirely out of APM Server (#3606) then we may as well remove the logging now.

@axw axw added the bug label Aug 31, 2020
@axw
Copy link
Member Author

axw commented Aug 31, 2020

Some kind of notification in the UI would likely be more visible to users. That could be done in a similar way, by identifying services without version defined.

simitt added a commit to simitt/apm-server that referenced this issue Sep 2, 2020
Remove unnecessary log line and change other from warning to debug level.

fixes elastic#4119
@simitt simitt self-assigned this Sep 2, 2020
@simitt simitt mentioned this issue Sep 2, 2020
2 tasks
simitt added a commit that referenced this issue Sep 3, 2020
Remove unnecessary log line and change other from warning to debug level.

fixes #4119
simitt added a commit to simitt/apm-server that referenced this issue Sep 3, 2020
Remove unnecessary log line and change other from warning to debug level.

fixes elastic#4119
simitt added a commit that referenced this issue Sep 4, 2020
Remove unnecessary log line and change other from warning to debug level.

fixes #4119
@axw axw removed the [zube]: Done label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants