add kubernetes and container fields #1785
Conversation
also defines all supported container.* and kubernetes.* now that libbeat can support it, to clean up tests and customize field descriptions
| @@ -295,6 +311,16 @@ | |||
| "platform": "darwin" | |||
| } | |||
| }, | |||
| "kubernetes": { | |||
| "namespace": "namespace1", | |||
| "node": { | |||
There was a problem hiding this comment.
out of curiosity, why don't we have same fields as ECS (eg we have node, but not container, labels, etc)?
There was a problem hiding this comment.
I think it's because this is the only information we're able to retrieve from within a container.
| "maxLength": 1024 | ||
| } | ||
| }, | ||
| "required": ["id"] |
There was a problem hiding this comment.
this is required so as to not have an empty container?
if so, probably i am overthinking this, but it could happen that an id is not possible to retrieve in some case, then at some point we add another field under container like name, but agents can't send container.name without a container.id?
|
Thanks @jalvz. The corresponding libbeat update is now approved but can't be merged yet due to CI issues - what do you think about merging this now (after resolving conflicts) and following with a beats update? |
|
👍 |
Conflicts: include/fields.go model/metadata/metadata.go processor/stream/package_tests/metadata_attrs_test.go processor/stream/package_tests/span_attrs_test.go testdata/intake-v2/errors.ndjson testdata/intake-v2/transactions.ndjson testdata/intake-v2/transactions_spans.ndjson
|
jenkins, retest this please |
2 similar comments
|
jenkins, retest this please |
|
jenkins, retest this please |
replaces #1651
relies on elastic/beats#10060
fixes #1621