-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kubernetes and container fields #1785
Conversation
also defines all supported container.* and kubernetes.* now that libbeat can support it, to clean up tests and customize field descriptions
@@ -295,6 +311,16 @@ | |||
"platform": "darwin" | |||
} | |||
}, | |||
"kubernetes": { | |||
"namespace": "namespace1", | |||
"node": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, why don't we have same fields as ECS (eg we have node, but not container, labels, etc)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's because this is the only information we're able to retrieve from within a container.
"maxLength": 1024 | ||
} | ||
}, | ||
"required": ["id"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is required so as to not have an empty container
?
if so, probably i am overthinking this, but it could happen that an id
is not possible to retrieve in some case, then at some point we add another field under container
like name
, but agents can't send container.name
without a container.id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Thanks @jalvz. The corresponding libbeat update is now approved but can't be merged yet due to CI issues - what do you think about merging this now (after resolving conflicts) and following with a beats update? |
👍 |
Conflicts: include/fields.go model/metadata/metadata.go processor/stream/package_tests/metadata_attrs_test.go processor/stream/package_tests/span_attrs_test.go testdata/intake-v2/errors.ndjson testdata/intake-v2/transactions.ndjson testdata/intake-v2/transactions_spans.ndjson
jenkins, retest this please |
2 similar comments
jenkins, retest this please |
jenkins, retest this please |
replaces #1651
relies on elastic/beats#10060
fixes #1621