Vendor go.opentelemetry.io/collector #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
axw
force-pushed
the
vendor-otel-collector
branch
4 times, most recently
from
5e74568
to
93b2242
Compare
Add a script to vendor go.opentelemetry.io/collector, along with mixin sources in "internal/.otel_collector_mixin", into "internal/otel_collector". The script will update go.mod to use this as a local replacement. Run this as part of the "go-generate" make target. We also add a requirement on go-licence-detector 0.5.0, which added support for local module replacements.
axw
force-pushed
the
vendor-otel-collector
branch
from
93b2242
to
dcda5c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4660 +/- ##
==========================================
+ Coverage 76.06% 76.10% +0.04%
==========================================
Files 161 161
Lines 9898 9899 +1
==========================================
+ Hits 7529 7534 +5
+ Misses 2369 2365 -4
|
|
jenkins run the tests please |
jalvz
approved these changes
Feb 1, 2021
axw
added a commit
to axw/apm-server
that referenced
this pull request
Feb 18, 2021
* Support vendoring go.opentelemetry.io/collector Add a script to vendor go.opentelemetry.io/collector, along with mixin sources in "internal/.otel_collector_mixin", into "internal/otel_collector". The script will update go.mod to use this as a local replacement. Run this as part of the "go-generate" make target. We also add a requirement on go-licence-detector 0.5.0, which added support for local module replacements. * Vendor go.opentelemetry.io/collector * Fix goimports
axw
added a commit
that referenced
this pull request
Feb 18, 2021
[7.x] Vendor go.opentelemetry.io/collector (#4660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Vendor
go.opentelemetry.io/collector, with some additional "mixin" sources, intointernal/otel_collector. We add a local module replacement togo.modso we can use the usual import paths.This is necessary to support registering the OTLP/gRPC services with our gmux'ed gRPC server, as the registration functions are in an inaccessible internal package in
go.opentelemetry.io. We mix in some functions to expose them.The first commit is hand-written, the second commit is the generated output. Reviewers should focus on the first.
How to test these changes
Non-functional change.
Related issues
Required for #4503