Add support for receiving traces over OTLP/gRPC #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
Add the gRPC service for receiving OTLP traces, and plumb it through to processor/otel. Auth works by setting the "Authorization" header (gRPC request metadata) like in HTTP requests.
|
jenkins run the tests please |
simitt
approved these changes
Feb 5, 2021
|
@bmorelli25 I run a small local app in go, basically following https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp#example-package-Insecure. |
|
Test failure is unrelated, see #4692 |
axw
added a commit
to axw/apm-server
that referenced
this pull request
Feb 18, 2021
Add the gRPC service for receiving OTLP traces, and plumb it through to processor/otel. Auth works by setting the "Authorization" header (gRPC request metadata) like in HTTP requests. # Conflicts: # NOTICE.txt # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Feb 18, 2021
Add the gRPC service for receiving OTLP traces, and plumb it through to processor/otel. Auth works by setting the "Authorization" header (gRPC request metadata) like in HTTP requests. # Conflicts: # NOTICE.txt # changelogs/head.asciidoc
|
I have successfully tested traces and metrics with
receivers:
otlp:
protocols:
grpc:
endpoint: '127.0.0.1:4317'
hostmetrics:
collection_interval: 1m
scrapers:
# cpu not supported on MacOS
# cpu:
load:
memory:
processors:
batch: null
exporters:
logging:
loglevel: info
prometheus:
endpoint: 0.0.0.0:8889
otlp/elastic:
endpoint: "localhost:8200"
insecure: true
headers:
Authorization: "Bearer my_secret_token"
service:
pipelines:
metrics:
receivers:
- otlp
- hostmetrics
exporters:
- prometheus
- otlp/elastic
traces:
receivers:
- otlp
processors:
- batch
exporters:
- otlp/elastic
|
|
Thanks for testing it out @cyrille-leclerc! |
|
Tested with BC 2 - Worked with the elastic and the otel exporter. |
|
Hello team, In this page, as well as in the official APM doc: https://www.elastic.co/guide/en/apm/guide/current/open-telemetry-direct.html#instrument-apps-otel We see this example being used every time: Is it possible to make this example Thank you |
|
@patpatpat123 I don't know if there even is any such code, or if it was just a made up example class name. If you're looking for a demo application to instrument with OpenTelemetry, then you should consider using OpenTelemetry Demo: https://github.com/open-telemetry/opentelemetry-demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Add the gRPC service for receiving OTLP traces, and plumb it through to
processor/otel. Once this lands we can follow up with:We use an interceptor for ensuring clients are authorised. Auth works by setting the "Authorization" header (gRPC request metadata) just like in HTTP requests.
Checklist
- [ ] Documentation has been updated(I will create a separate issue for this)How to test these changes
insecure: truein the exporter config, unless APM Server is configured to use TLS.headers: {'Authorization': 'Bearer secret_token'}, restart opentelemetry-collectorRelated issues
#4503