Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS ECS Fargate container ID regex. #888

Open
8 of 13 tasks
Mpdreamz opened this issue Sep 4, 2024 · 0 comments
Open
8 of 13 tasks

Update AWS ECS Fargate container ID regex. #888

Mpdreamz opened this issue Sep 4, 2024 · 0 comments

Comments

@Mpdreamz
Copy link
Member

Mpdreamz commented Sep 4, 2024

Description

As per #886

We have new evidence that ID part of ECS Fargate container may end in 1 to 10 digits not exactly 10 digits.

And As per #887

Through a customer support case, we've been notified of a failure to parse the container ID from /proc/self/cgroup for a service running on ECS Fargate. In this customer's case, the container ID does not seem to conform to the expected format of the Docker ID in AWS ECS Fargate, which, per this documentation, is expected to be 32 hex characters followed by a dash and then ten numeric digits.

In this customer case, in two out of 30 services, there are only nine numeric digits after the dash. It is unclear if this is a bug in AWS, but as it is not documented, it could well be. AWS support has been unable to reproduce this on their end. Since our specification uses a strict regex to match the possibility of an ECS Fargate format, for this customer, our APM agents will be unable to parse the container ID while using our regex.

We in fact observed a new case since ending in 8 digits.

This issue is created to track everyone updating their regex for ECS Fargate container IDs to:

^[[:xdigit:]]{32}-[[:digit:]]{1,10}$

To be up to date with the specification change from: #886

Issues creation

Create Spec issue?

  • Spec issue

Create APM Agent issues?

  • elastic-otel-java
  • elastic-otel-dotnet
  • elastic-otel-node
  • elastic-otel-python
  • elastic-otel-php
  • apm-agent-java
  • apm-agent-dotnet
  • apm-agent-nodejs
  • apm-agent-python
  • apm-agent-go
  • apm-agent-php
  • apm-agent-ruby
trentm added a commit to elastic/apm-agent-nodejs that referenced this issue Sep 4, 2024
trentm added a commit to elastic/apm-agent-nodejs that referenced this issue Sep 4, 2024
david-luna pushed a commit to elastic/apm-agent-nodejs that referenced this issue Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant