Add support to collects tags in RDS (AWS module)

[tony2k84]

Describe the enhancement:
AWS module - RDS metric set doesn't include tags. This is a very standard mechanism to include specific metadata for resources. All services discovered should have tags.

Describe a specific use case for the enhancement or feature:
Ex. our implementation keeps application name tied to a database (RDS) in the tags object in AWS. There is no way in metric beat to get that information.

[kaiyan-sheng]

@tony2k84 Thanks for reporting this issue. You are absolutely right for needing tags in rds metricset. I just created a PR to add this. Thank you!

[eedugon]

@kaiyan-sheng , for curiosity... will the PR provide the tags on the RDS events and also allow configuring the metricset to filter certain tags for the input too?

Like with other AWS metricsets where we can filter what to monitor via tags_filter.

[tony2k84]

What is the timeline for tags PR for RDS. Regards, Abhishek Tanwar

…

________________________________ From: kaiyan-sheng <[email protected]> Sent: Monday, March 2, 2020 4:21:39 PM To: elastic/beats <[email protected]> Cc: tony2k84 <[email protected]>; Mention <[email protected]> Subject: Re: [elastic/beats] Add support to collects tags in RDS (was module) (#16358) Good question @eedugon<https://github.com/eedugon>, I'm planning to add tags_filter for RDS and EC2 metricsets together in a separate PR after this one is merged. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#16358?email_source=notifications&email_token=ACX7PLVQMVTO5L64YS5YHA3RFPFIHA5CNFSM4KVXLJHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENPWSYQ#issuecomment-593455458>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACX7PLVXEXQOTP2M3KXRJTTRFPFIHANCNFSM4KVXLJHA>.

[kaiyan-sheng]

@eedugon Sorry I was thinking EC2 metricset needs the tags_filter as well. Turned out it already has it. So I will add tags_filter for RDS in this same PR. Thanks!

[tony2k84]

@kaiyan-sheng I am really looking for this to be implemented - any idea on the merge for this one?

[kaiyan-sheng]

@tony2k84 This PR just got merged into master branch. Sorry for the delay!