Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config validation in winlogbeat #21220

Closed
leehinman opened this issue Sep 22, 2020 · 1 comment · Fixed by #21593
Closed

Improve config validation in winlogbeat #21220

leehinman opened this issue Sep 22, 2020 · 1 comment · Fixed by #21593
Assignees
@leehinman
Labels
Winlogbeat

Comments

@leehinman
Copy link
Contributor

leehinman commented Sep 22, 2020 •
edited by andresrc
Loading

Describe the enhancement:

configuration validation in winlogbeat/eventlog/factory.go is brittle and can be broken by new fields outside the scope of eventlog input.

Describe a specific use case for the enhancement or feature:
make ongoing support easier

Related #21205
@leehinman leehinman self-assigned this Sep 22, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 22, 2020
@leehinman leehinman added needs_backport PR is waiting to be backported to other branches. Team:SIEM Winlogbeat labels Sep 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 22, 2020
@leehinman leehinman mentioned this issue Oct 6, 2020
Merged
1 task
leehinman added a commit to leehinman/beats that referenced this issue Oct 7, 2020
@leehinman
Remove brittle configuration validation from wineventlog
60a39fd 
- removed config keys checking

Closes elastic#21220
leehinman added a commit that referenced this issue Oct 8, 2020
@leehinman
[Winlogbeat] Remove brittle configuration validation from wineventlog (…
5b69349 
…#21593)

* Remove brittle configuration validation from wineventlog

- removed config keys checking
- update unit tests

Closes #21220
@leehinman leehinman mentioned this issue Oct 8, 2020
Merged
1 task
leehinman added a commit to leehinman/beats that referenced this issue Oct 8, 2020
@leehinman
[Winlogbeat] Remove brittle configuration validation from wineventlog (…
291d259 
…elastic#21593)

* Remove brittle configuration validation from wineventlog

- removed config keys checking
- update unit tests

Closes elastic#21220

(cherry picked from commit 5b69349)
leehinman added a commit that referenced this issue Oct 13, 2020
@leehinman
[Winlogbeat] Remove brittle configuration validation from wineventlog (…
c82c4a3 
…#21593) (#21691)

* Remove brittle configuration validation from wineventlog

- removed config keys checking
- update unit tests

Closes #21220

(cherry picked from commit 5b69349)
@andrewkroh andrewkroh removed the needs_backport PR is waiting to be backported to other branches. label Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leehinman leehinman

Labels
Winlogbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Winlogbeat] Remove brittle configuration validation from wineventlog leehinman/beats
3 participants
@andrewkroh @elasticmachine @leehinman