Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator tests are failing on master #28361

Closed
kvch opened this issue Oct 12, 2021 · 1 comment
Closed

Generator tests are failing on master #28361

kvch opened this issue Oct 12, 2021 · 1 comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@kvch
Copy link
Contributor

kvch commented Oct 12, 2021

After updating Golang to 1.17, generator packaging tests started to fail with the following error:

../../../pkg/mod/github.com/elastic/beats/[email protected]/dev-tools/packaging/package_test.go:39:2: missing go.sum entry for module providing package github.com/blakesmith/ar; to add:
        go mod download github.com/blakesmith/ar

@kvch kvch added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

andrewkroh added a commit to andrewkroh/beats that referenced this issue Oct 13, 2021
andrewkroh added a commit that referenced this issue Oct 18, 2021
* Fix modified go.sum issue in beat generators

There were two issues:

`go mod download` was run after the newly generated beat was committed. This modified the go.sum because it
adds hashes for the downloaded dependencies. The caused `mage check` to fail because the git project has
pending changes.

The dependencies of package_test.go were missing from go.sum. When running `mage testPackages` it
was failing because github.com/blakesmith/ar and github.com/cavaliercoder/go-rpm were missing.

* Re-enable generator tests

Relates #28361
mergify bot pushed a commit that referenced this issue Oct 18, 2021
* Fix modified go.sum issue in beat generators

There were two issues:

`go mod download` was run after the newly generated beat was committed. This modified the go.sum because it
adds hashes for the downloaded dependencies. The caused `mage check` to fail because the git project has
pending changes.

The dependencies of package_test.go were missing from go.sum. When running `mage testPackages` it
was failing because github.com/blakesmith/ar and github.com/cavaliercoder/go-rpm were missing.

* Re-enable generator tests

Relates #28361

(cherry picked from commit 81f32e7)
andrewkroh added a commit that referenced this issue Oct 18, 2021
* Fix modified go.sum issue in beat generators

There were two issues:

`go mod download` was run after the newly generated beat was committed. This modified the go.sum because it
adds hashes for the downloaded dependencies. The caused `mage check` to fail because the git project has
pending changes.

The dependencies of package_test.go were missing from go.sum. When running `mage testPackages` it
was failing because github.com/blakesmith/ar and github.com/cavaliercoder/go-rpm were missing.

* Re-enable generator tests

Relates #28361

(cherry picked from commit 81f32e7)

Co-authored-by: Andrew Kroh <[email protected]>
@kvch kvch closed this as completed Oct 27, 2021
Icedroid pushed a commit to Icedroid/beats that referenced this issue Nov 1, 2021
* Fix modified go.sum issue in beat generators

There were two issues:

`go mod download` was run after the newly generated beat was committed. This modified the go.sum because it
adds hashes for the downloaded dependencies. The caused `mage check` to fail because the git project has
pending changes.

The dependencies of package_test.go were missing from go.sum. When running `mage testPackages` it
was failing because github.com/blakesmith/ar and github.com/cavaliercoder/go-rpm were missing.

* Re-enable generator tests

Relates elastic#28361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

No branches or pull requests

2 participants