Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #10029 to 6.6: Handle IPv6 zone id in IIS filebeat ingest pipeline for access logs too #10030

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Jan 11, 2019

Cherry-pick of PR #10029 to 6.6 branch. Original message:

This is a manual backport, to fix an issue with the iis module, with regards to IP literals containing an IPv6 zone ID (issue #9836). This was fixed in master as part of the ECS conversion of the iis module (#9955).

Contrary to the fix in master, this fix is in line with Jaime's fix for the IIS error logs (#9869, #9932, #9933). This means the IP literal is saved as is to iis.access.remote_ip (including the zone). This is fine, because this is a keyword field. The GeoIP processor then uses an IP literal with the zone stripped out, to avoid hitting the error. Note that this cleaned up field is not kept around in the 6.x line.

@webmat webmat requested a review from jsoriano January 11, 2019 20:48
@webmat webmat self-assigned this Jan 11, 2019
@webmat webmat changed the title Cherry-pick to 6.6: Handle IPv6 zone id in IIS filebeat ingest pipeline for access logs too Cherry-pick #10029 to 6.6: Handle IPv6 zone id in IIS filebeat ingest pipeline for access logs too Jan 11, 2019
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webmat webmat merged commit e05f967 into elastic:6.6 Jan 14, 2019
@webmat webmat deleted the backport-iis-access-ipv6zone-fix-6.6 branch January 14, 2019 13:50
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Jan 14, 2019
… ingest pipeline for access logs too (elastic#10030)

(cherry picked from commit e05f967)
jsoriano added a commit that referenced this pull request Jan 21, 2019
…beat ingest pipeline (#10057)

IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit d59ae8c)
(cherry picked from commit 5f1f6ca)
(cherry picked from commit e05f967)

Co-authored-by: Mathieu Martin <[email protected]>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…id in IIS filebeat ingest pipeline (elastic#10057)

IIS logs can include zone ids when using IPv6, this is correctly parsed
but geoip processor doesn't accept these addresses. Create a temporary
field without the zone id to be used by geoip processor.

(cherry picked from commit dad84e9)
(cherry picked from commit 5f1f6ca)
(cherry picked from commit e05f967)

Co-authored-by: Mathieu Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants