Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Migrate ETCD Store to use ReporterV2 interface #10815

Merged
merged 5 commits into from
Feb 22, 2019

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Feb 18, 2019

Refer to #10774 for more info

@sayden sayden added Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Feb 18, 2019
@sayden sayden self-assigned this Feb 18, 2019
@sayden sayden requested a review from a team as a code owner February 18, 2019 22:20
@sayden
Copy link
Contributor Author

sayden commented Feb 19, 2019

jenkins, test this again please because No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@sayden
Copy link
Contributor Author

sayden commented Feb 20, 2019

Error seems unrelated in Elasticsearch module https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/beat=metricbeat,label=linux-immutable/5213/console

I think we have a flaky test there

@sayden
Copy link
Contributor Author

sayden commented Feb 21, 2019

Issue opened describing the flaky test #10866

@jsoriano
Copy link
Member

Error seems unrelated in Elasticsearch module https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/beat=metricbeat,label=linux-immutable/5213/console

I think we have a flaky test there

This error looks like if the container died, not sure if we should consider this flaky.

@sayden
Copy link
Contributor Author

sayden commented Feb 22, 2019

Propose the name you want to give it here if you want 😉 #10866

The point is that it shouldn't fail when unrelated code is pushed and it should be fixed somehow, call it flaky test or task.

@sayden sayden merged commit af41b93 into elastic:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants