Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not skip test_file_disappear_appear on Windows anymore #10820

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Do not skip test_file_disappear_appear on Windows anymore #10820

merged 1 commit into from
Feb 20, 2019

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Feb 19, 2019

Fixes around detecting the deletion of a file on Windows are possibly fixed this issue: #10747

I am triggering a few Jenkins builds to see if the theory holds up.

Closes #9213

@kvch kvch added review Filebeat Filebeat labels Feb 19, 2019
@kvch kvch requested a review from urso February 19, 2019 08:59
@kvch kvch requested a review from a team as a code owner February 19, 2019 08:59
@kvch kvch added the in progress Pull request is currently in progress. label Feb 19, 2019
@kvch
Copy link
Contributor Author

kvch commented Feb 19, 2019 •
edited
Loading

First round is successful on Windows.

@kvch
Copy link
Contributor Author

kvch commented Feb 19, 2019

jenkins test this

1 similar comment
@kvch
Copy link
Contributor Author

kvch commented Feb 19, 2019

jenkins test this

urso
urso approved these changes Feb 19, 2019
View reviewed changes
Copy link

@urso urso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an easy fix.

@kvch kvch merged commit 3950fc6 into elastic:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees
No one assigned
Labels
Filebeat Filebeat in progress Pull request is currently in progress. review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] Flaky test test_crawler.Test.test_file_disappear_appear
2 participants
@kvch @urso