[Filebeat] Skip flaky windows tests #11540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test_clean_inactive` (elastic#8102) and `test_clean_removed` (elastic#7690) have been flaky recently again on Windows. Skipping these test for Windows.
ruflin
added
review
Filebeat
kvch
approved these changes
Apr 1, 2019
|
We should collect recent artifacts + logs. It might be a timing issue. Maybe just increasing timeouts on Windows helps. I actually reduced the timeouts when fixing some bugs and it seemed to be green for a while. |
|
@urso I saw it several times last week. Were your fix before or after? I did not collect the artifacts as I saw there is already an open issue for it, but probably should have :-( |
|
Fix was merged mid February: #10747 |
|
@urso test_clean_inactive was failing again on a PR not rebased on master yet. I added the artifacts to the related isseu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_clean_inactive(#8102) andtest_clean_removed(#7690) have been flaky recently again on Windows. Skipping these test for Windows.