[Heartbeat] Remove not needed flags from setup command #12350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of elastic#11856 to 6.8 The setup command until now contained all the possible options from the other Beats. As Heartbeat does not ship anymore with dashboards, the --dashboards command is not needed anymore and is only confusing. I also removed all the other commands except --ilm-policy and --template. I'm not aware that --pipelines or --machine-learning would be used. Here the comparison between ./heartbeat setup -h from before and after.
andrewvc
added
backport
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime |
houndci-bot
reviewed
May 29, 2019
|
I thought we removed the dashboards for 7.0. Did we already remove them in 6.x? |
|
@ruflin you are right! We still need them in 6.x! |
|
Closing, since we don't need to remove dashboards in 6.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11856 to 6.8
Fixes elastic/kibana#37216
The setup command until now contained all the possible options from the other Beats. As Heartbeat does not ship anymore with dashboards, the --dashboards command is not needed anymore and is only confusing. I also removed all the other commands except --ilm-policy and --template. I'm not aware that --pipelines or --machine-learning would be used.
Here the comparison between ./heartbeat setup -h from before and after.