Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a race condition in the TCP input #13038

Merged
merged 7 commits into from
Jul 25, 2019
Merged

Fix a race condition in the TCP input #13038

merged 7 commits into from
Jul 25, 2019

Commits on Jul 23, 2019

  1. Fix a race condition in the TCP input

    Pass the `net.Conn` object when creating the client instead of passing it to the
    `Handle()` method that keep a reference to it. By doing this we do not
    have to worry about read or write race over the internal field. The
    client still need a reference to the connection when the out of bound
    call to `Close()` is executed to make sure we are getting out of a
    `Read()` call early.
    
    Tested with :
    
    ```
    while true; do go test -v -race; done
    ```
    
    Found in elastic#13021
    ph committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    6367711 View commit details
    Browse the repository at this point in the history
  2. Add changelog

    ph committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    f9e6499 View commit details
    Browse the repository at this point in the history
  3. add pr number

    ph committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    04f7b61 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. Configuration menu
    Copy the full SHA
    cac1647 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a01c6b0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    45030d8 View commit details
    Browse the repository at this point in the history
  4. missing header

    ph committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    7e328bc View commit details
    Browse the repository at this point in the history