Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing node name to use DATA grok pattern #14547

Merged
merged 3 commits into from
Nov 18, 2019

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Nov 15, 2019

Previously, the elasticsearch/slowlog fileset was parsing the node name field using the WORD grok pattern, which does not allow for characters such as -. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-accepting DATA grok pattern.

Previously, the node name field was being parsed using the `WORD` grok patterns, which does not allow for characters such as `-` in the node name. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-accepting `DATA` grok pattern.
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator
Copy link
Contributor Author

Travis CI is green. Jenkins CI failures are unrelated to this PR. Merging.

@ycombinator ycombinator merged commit 91df3a5 into elastic:master Nov 18, 2019
@ycombinator ycombinator deleted the fb-es-slowlog-node-name branch November 18, 2019 11:08
ycombinator added a commit that referenced this pull request Nov 19, 2019
* Fixing node name to use `DATA` grok pattern

Previously, the node name field was being parsed using the `WORD` grok patterns, which does not allow for characters such as `-` in the node name. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-accepting `DATA` grok pattern.

* Adding sample log entry

* Adding CHANGELOG entry
ycombinator added a commit that referenced this pull request Nov 20, 2019
* Fixing node name to use `DATA` grok pattern (#14547)

* Fixing node name to use `DATA` grok pattern

Previously, the node name field was being parsed using the `WORD` grok patterns, which does not allow for characters such as `-` in the node name. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-accepting `DATA` grok pattern.

* Adding sample log entry

* Adding CHANGELOG entry

* Fixing CHANGELOG
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…astic#14583)

* Fixing node name to use `DATA` grok pattern (elastic#14547)

* Fixing node name to use `DATA` grok pattern

Previously, the node name field was being parsed using the `WORD` grok patterns, which does not allow for characters such as `-` in the node name. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-accepting `DATA` grok pattern.

* Adding sample log entry

* Adding CHANGELOG entry

* Fixing CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants