-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make check for python 3 #15226
Fix make check for python 3 #15226
Conversation
It does not seem to fix the build. :( |
Thanks @kvch . I'm guessing you're referring to the travis-ci jobs? I wonder if this is an issue with an older Python in Travis CI? @jsoriano Is there a minimum python 3.x that we're targeting?
|
I wonder if we need to update the version of Ubuntu used for our travis-ci jobs. We're using Ubuntu 14.04 (Trusty) which looks like it ships with Python 3.4. We may need to switch to Ubuntu 16.04 (Xenial) or 18.04 (Bionic). I've been doing my testing on Ubuntu 18.04.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! If travis likes it, I like it!
I wonder if this is an issue with an older Python in Travis CI? @jsoriano Is there a minimum python 3.x that we're targeting?
We haven't decided a minimum version to support, but in any case we shouldn't care about deprecated or unmaintained versions, so no worries if this doesn't work with Python 3.4.
There was a point about upgrading python, or the base image in Travis in #14798, I have added this PR as fix for that.
There are around 11 failures unrelated to |
* Run autopep on script/update_golang_x.py to fix make check * Update travis to use Ubuntu Bionic
make check
works fine on Ubuntu 18.04 after this fix.