Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python instead of the base image for python 3 #15931

Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jan 29, 2020

Travis builds are taking too long in the python 3 branch after upgrading the Ubuntu image.
Keeping the image in trusty seems to speed up the builds. Timeouts disappear.
So instead of upgrading the image, upgrade python to 3.6 using deadsnakes PPA,
this is the minimal version for venv to work properly.
Python 3.7 doesn't work well because the trusty image in Travis has an old openssl version,
and Python 3.8 is not available for trusty.

Failures in tests after this change are consistent with failures in linux build in Jenkins.

@jsoriano jsoriano self-assigned this Jan 29, 2020
@jsoriano jsoriano marked this pull request as ready for review January 29, 2020 14:41
@jsoriano jsoriano changed the title Try xenial instead of bionic Upgrade python instead of the base image for python 3 Jan 30, 2020
@jsoriano jsoriano mentioned this pull request Jan 30, 2020
63 tasks
Copy link
Contributor

@mikemadden42 mikemadden42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, I'm fine with moving forward. We can revisit upgrading the version of Ubuntu at a future time.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this makes it stable then let's move forward. We can investigate the slowness issue with bionic independent of the Python upgrade.

@jsoriano jsoriano merged commit 1037aeb into elastic:feature/python3 Jan 30, 2020
@jsoriano jsoriano deleted the python3-try-other-ubuntu-version branch January 30, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants