-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade python instead of the base image for python 3 #15931
Upgrade python instead of the base image for python 3 #15931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works, I'm fine with moving forward. We can revisit upgrading the version of Ubuntu at a future time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this makes it stable then let's move forward. We can investigate the slowness issue with bionic independent of the Python upgrade.
Travis builds are taking too long in the python 3 branch after upgrading the Ubuntu image.
Keeping the image in trusty seems to speed up the builds. Timeouts disappear.
So instead of upgrading the image, upgrade python to 3.6 using deadsnakes PPA,
this is the minimal version for venv to work properly.
Python 3.7 doesn't work well because the trusty image in Travis has an old openssl version,
and Python 3.8 is not available for trusty.
Failures in tests after this change are consistent with failures in linux build in Jenkins.