[Metricbeat] Add a linux module for platform-specific metrics in linux. #17267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
changed the title
|
Pinging @elastic/integrations (Team:Integrations) |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
ycombinator
reviewed
May 4, 2020
ycombinator
reviewed
May 4, 2020
urso
approved these changes
May 5, 2020
fearful-symmetry
added
[zube]: In Progress
needs_backport
8 tasks
fearful-symmetry
added
v7.8.0
and removed
needs_backport
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
May 5, 2020
…x. (elastic#17267) * init commit of linux module * init commit of conntrack metricset * code cleanup * update notice * run go vendor * make update * first draft of pef mertricset * first pass of linux/perf * update and merge * add build tags, disable tests * remove system-dependent tests * code cleanup * more code cleanup * fix docs, revert hostfs change * fmt, update * update with new upstream changes * code cleanup, work on PID checks * remove perf, revert to 3 metricsets * update notice * update config * mage update * fix formatting, comments * code cleanup (cherry picked from commit d59b149)
fearful-symmetry
added a commit
that referenced
this pull request
May 5, 2020
…rm-specific metrics in linux. (#18246) * [Metricbeat] Add a linux module for platform-specific metrics in linux. (#17267) * init commit of linux module * init commit of conntrack metricset * code cleanup * update notice * run go vendor * make update * first draft of pef mertricset * first pass of linux/perf * update and merge * add build tags, disable tests * remove system-dependent tests * code cleanup * more code cleanup * fix docs, revert hostfs change * fmt, update * update with new upstream changes * code cleanup, work on PID checks * remove perf, revert to 3 metricsets * update notice * update config * mage update * fix formatting, comments * code cleanup (cherry picked from commit d59b149) * mage fmt update
andresrc
added
test-plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is an attempt to avoid cluttering the
systemmodule with metricsets that are not broadly cross-compatible. Instead, this introduces alinuxmodule that contains metrics exclusive to the linux kernel and various subsystems. This is a draft PR that currently includes two metricsets:pageinfowhich collects metrics on the buddy paging algorithm, which can be used to determine memory fragmentation. The other isksm, which tracks the efficacy of kernel samepage merging. This is currently a draft, as it's already quite large and I'd rather have something to show while I continue work.Why is it important?
This module adds valueable OS-level metrics in line with similar solutions.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
ksmwill report no data unless a running application is making use of the KSM interface.