Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17600 to 7.x: [Metricbeat] add more metric collection into pubsub metricset #17651

Merged
merged 2 commits into from
Apr 12, 2020
Merged

Cherry-pick #17600 to 7.x: [Metricbeat] add more metric collection into pubsub metricset #17651

merged 2 commits into from
Apr 12, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 9, 2020

Cherry-pick of PR #17600 to 7.x branch. Original message:

What does this PR do?

This PR is to add more metric collection into pubsub metricset for subscription and topic. Also added all metrics for snapshot.

Why is it important?

This gives a full picture for gcp pubsub data collection, which matches what stackdriver has.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

#17154

* add more metric collection into pubsub metricset
* fix docs.asciidoc for pubsub

(cherry picked from commit 50c6e86)
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 9, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Apr 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kaiyan-sheng
Copy link
Contributor Author

jenkins, test this please

@kaiyan-sheng kaiyan-sheng merged commit f42e2fe into elastic:7.x Apr 12, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_17600_7.x branch April 12, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants