Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18958 to 7.x: [Filebeat] Improve AWS cloudtrail fileset #19023

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

leehinman
Copy link
Contributor

Cherry-pick of PR #18958 to 7.x branch. Original message:

What does this PR do?

Changes to AWS cloudtrail fileset, specifically:

  • adds geoip AS lookup on source.ip
  • improve mappings event.category
  • improve mappings for event.type

Why is it important?

  • geoip AS is used for detections
  • having correct mappings for event.category & event.type improves detections

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=aws TESTING_FILEBEAT_FILESETS=cloudtrail mage -v pythonIntegTest

Related issues

- add geoip AS lookup on source.ip
- improve mappings event.category
- improve mappings for event.type

Closes elastic#18644

(cherry picked from commit c01dfe6)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 5, 2020
@leehinman leehinman merged commit 4d30c52 into elastic:7.x Jun 8, 2020
@leehinman leehinman deleted the backport_18958_7.x branch October 5, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants