Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat][netflow] Support up to 7 bytepad for Netflow IPFIX template #19131

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 11, 2020

What does this PR do?

Fixes netflow v9 decoder to support up to 7 bytes of padding for IPFIX templates.

Why is it important?

Previously was failing to process packets with more than 3 bytes of padding.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Fixes #18098

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 11, 2020
@marc-gr marc-gr changed the title Support up to 7 bytepad for Netflow IPFIX template [filebeat][netflow[ Support up to 7 bytepad for Netflow IPFIX template Jun 11, 2020
@marc-gr marc-gr changed the title [filebeat][netflow[ Support up to 7 bytepad for Netflow IPFIX template [filebeat][netflow] Support up to 7 bytepad for Netflow IPFIX template Jun 11, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19131 updated]

  • Start Time: 2020-06-12T08:08:13.432+0000

  • Duration: 46 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 2346
Skipped 382
Total 2728

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@marc-gr marc-gr merged commit fb94175 into elastic:master Jun 15, 2020
@marc-gr marc-gr deleted the marc-gr/issue18098 branch June 15, 2020 10:06
@marc-gr marc-gr added the v7.7.2 label Jun 15, 2020
marc-gr added a commit to marc-gr/beats that referenced this pull request Jun 15, 2020
@marc-gr marc-gr added the v7.8.0 label Jun 15, 2020
marc-gr added a commit to marc-gr/beats that referenced this pull request Jun 15, 2020
@marc-gr marc-gr added the v7.9.0 label Jun 15, 2020
marc-gr added a commit to marc-gr/beats that referenced this pull request Jun 15, 2020
Generate golden file for 7.7

Fixes elastic#18098

(cherry picked from commit fb94175)
marc-gr added a commit that referenced this pull request Jun 15, 2020
Generate golden file for 7.7

Fixes #18098

(cherry picked from commit fb94175)
marc-gr added a commit that referenced this pull request Jun 15, 2020
marc-gr added a commit that referenced this pull request Jun 15, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netflow module v7.6 doesn’t support 4-7 byte pad in IPFIX template sets
3 participants