[Ingest Manager] Use libbeat logger #19211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
review
needs_backport
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
michalpristas
commented
Jun 16, 2020
ph
reviewed
Jun 17, 2020
| type loggingLevel logp.Level | ||
|
|
||
| var loggingLevelMap = map[string]loggingLevel{ | ||
| "trace": loggingLevel(logp.DebugLevel), // For backward compatibility |
There was a problem hiding this comment.
Trace was only for us? correct? we can remove that.
| # Sets output of logging. Available options are `console`, `file`. | ||
| # File output is located at `data/logs/elastic-agent` | ||
| # logging.output: console | ||
|
|
There was a problem hiding this comment.
The reference file should be more complete https://github.com/elastic/beats/blob/master/libbeat/_meta/config/logging.reference.yml.tmpl
There was a problem hiding this comment.
what i dont like in to_xxx configuration options is that it evokes that you can set true to more than one and it will work, having a single option with a single value makes it clear there's no way of having 2 outputs of logging.
i will introduce some more options or i can even make it 1;1 and let libbeat logger handle that without any verification from our side.
There was a problem hiding this comment.
I do not like it either but I am into moving responsibility out if possible, @urso is there a plan to change the logging options?
|
@michalpristas Few changes I see.
|
ph
reviewed
Jun 18, 2020
| JSON bool `config:"json"` // Write logs as JSON. | ||
| Level Level `config:"level"` // Logging level (error, warning, info, debug). | ||
| Selectors []string `config:"selectors"` // Selectors for debug level logging. | ||
| ECSEnabled bool `config:"ecs"` // Adds minimal ECS information using ECS conformant keys to every log line |
There was a problem hiding this comment.
ECS is on by default here https://github.com/elastic/beats/pull/19211/files#diff-7b5f5c8d014c26b7f6c249cb83fb54b9R101
ph
approved these changes
Jun 26, 2020
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Jul 1, 2020
[Ingest Manager] Use libbeat logger (elastic#19211)
6 tasks
michalpristas
added a commit
that referenced
this pull request
Jul 2, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
[Ingest Manager] Use libbeat logger (elastic#19211)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes our dependency on ecs logger and uses libbeat logger by default.
By default we log to file now, so users can share logs easier.
Why is it important?
ECS compliant logging.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Fixes: #15129