Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify input type configuration options #19284

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

ppf2
Copy link
Member

@ppf2 ppf2 commented Jun 18, 2020

Clarify that all input type configuration options must be specified within the external configuration file: #19148. Perhaps we can backport the doc change to all beat versions.

Clarify that all input type configuration options must be specified within the external configuration file: #19148
@ppf2 ppf2 requested a review from ycombinator June 18, 2020 16:53
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 18, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 18, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-13T10:43:20.906+0000

  • Duration: 23 min 28 sec

@urso urso added the docs label Jun 18, 2020
@urso urso requested a review from dedemorton June 18, 2020 19:56
@andresrc andresrc added the Team:Services (Deprecated) Label for the former Integrations-Services team label Jun 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 22, 2020
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Really sorry about the delay in reviewing. I kind of rely on GitHub notifications, but I guess I shouldn't.

@botelastic
Copy link

botelastic bot commented Aug 20, 2020

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 20, 2020
@botelastic botelastic bot removed the Stalled label Sep 17, 2020
@dedemorton dedemorton merged commit e50c9b3 into master Oct 3, 2020
@dedemorton dedemorton deleted the ppf2-clarify-input-type-configs branch October 3, 2020 02:40
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Oct 3, 2020
Clarify that all input type configuration options must be specified within the external configuration file: elastic#19148
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Oct 3, 2020
Clarify that all input type configuration options must be specified within the external configuration file: elastic#19148
v1v added a commit to v1v/beats that referenced this pull request Oct 5, 2020
…-matches-found

* upstream/master: (21 commits)
  Skip filestream flaky tests (elastic#21490)
  Ignore unsupported metrics in the azure module (elastic#21486)
  Do not run symlink tests on Windows (elastic#21472)
  Map `cloud.account.id` to azure sub id (elastic#21483)
  Add support for app_state metricset (elastic#20639)
  Include original error when metricbeat fails to connect with Kafka (elastic#21484)
  Prompt only when agent is already enrolled (elastic#21473)
  Fix leftover delpoyment example (elastic#21474)
  Bump version to ECS 1.6 in modules without ECS updates (elastic#21455)
  Clarify input type configuration options (elastic#19284)
  Increase index pattern size check to 10MiB (elastic#21487)
  Migrate S3 Input to Filebeat Input V2 (elastic#20005)
  [libbeat] Add configurable exponential backoff for disk queue write errors (elastic#21493)
  Revert "Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)" (elastic#21467)
  Fix format of debug messages in tlscommon (elastic#21482)
  [CI] Change x-pack/auditbeat build events (comments, labels) (elastic#21463)
  [CI] changeset from elastic#20603 was not added to CI2.0 (elastic#21464)
  Add new log file reader for filestream input (elastic#21450)
  [CI] Send slack message with build status (elastic#21428)
  Remove duplicated sources url in dependencies report (elastic#21462)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 5, 2020
* upstream/master: (26 commits)
  [Ingest Manager] Send updating state (elastic#21461)
  [Filebeat][New Fileset] Cisco Umbrella support (elastic#21504)
  [Ingest Manager] Download asc from artifact store specified in spec (elastic#21488)
  Implementation of fileProspector (elastic#21479)
  [Metricbeat] Add latency config option into aws module (elastic#20875)
  Skip filestream flaky tests (elastic#21490)
  Ignore unsupported metrics in the azure module (elastic#21486)
  Do not run symlink tests on Windows (elastic#21472)
  Map `cloud.account.id` to azure sub id (elastic#21483)
  Add support for app_state metricset (elastic#20639)
  Include original error when metricbeat fails to connect with Kafka (elastic#21484)
  Prompt only when agent is already enrolled (elastic#21473)
  Fix leftover delpoyment example (elastic#21474)
  Bump version to ECS 1.6 in modules without ECS updates (elastic#21455)
  Clarify input type configuration options (elastic#19284)
  Increase index pattern size check to 10MiB (elastic#21487)
  Migrate S3 Input to Filebeat Input V2 (elastic#20005)
  [libbeat] Add configurable exponential backoff for disk queue write errors (elastic#21493)
  Revert "Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)" (elastic#21467)
  Fix format of debug messages in tlscommon (elastic#21482)
  ...
dedemorton added a commit that referenced this pull request Oct 5, 2020
Clarify that all input type configuration options must be specified within the external configuration file: #19148

Co-authored-by: Pius <[email protected]>
dedemorton added a commit that referenced this pull request Oct 5, 2020
Clarify that all input type configuration options must be specified within the external configuration file: #19148

Co-authored-by: Pius <[email protected]>
@zube zube bot removed the [zube]: Done label Jan 1, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Clarify that all input type configuration options must be specified within the external configuration file: elastic#19148

Co-authored-by: Pius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants