Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fortinet.firewall.mem value to be interpreted as integer #19335

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Fix fortinet.firewall.mem value to be interpreted as integer #19335

merged 3 commits into from
Aug 11, 2020

Conversation

philippkahr
Copy link
Contributor

@philippkahr philippkahr commented Jun 23, 2020

What does this PR do?

Interpret fortinet.firewall.mem as integer instead of keyword

Why is it important?

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run filebeat tests locally e.g.

./filebeat.test GENERATE=1 INTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false TESTING_FILEBEAT_MODULES=fortinet nosetests tests/system/test_modules.py

PYTEST_ADDOPTS="-k fortinet" mage -v pythonIntegTest

Related issues

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 23, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 23, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19335 updated]

  • Start Time: 2020-08-11T01:00:09.203+0000

  • Duration: 52 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 5525
Skipped 846
Total 6371

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2020
@P1llus
Copy link
Member

P1llus commented Aug 10, 2020

Can confirm this change is good. Else you wont be able to aggregate on the value.

@andrewkroh
Copy link
Member

jenkins run tests

@andrewkroh andrewkroh added breaking change bug Filebeat Filebeat release-note:breaking The content should be included as a breaking change needs_backport PR is waiting to be backported to other branches. labels Aug 10, 2020
@andrewkroh andrewkroh merged commit e7c0b1d into elastic:master Aug 11, 2020
andrewkroh pushed a commit to andrewkroh/beats that referenced this pull request Aug 11, 2020
…#19335)

Fix fortinet.firewall.mem value to be interpreted as integer. Add convert processor for fortinet.firewall.mem to ingest pipeline.

Closes elastic#19327

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit e7c0b1d)
@andrewkroh andrewkroh added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 11, 2020
andrewkroh added a commit that referenced this pull request Aug 11, 2020
…#20542)

Fix fortinet.firewall.mem value to be interpreted as integer. Add convert processor for fortinet.firewall.mem to ingest pipeline.

Closes #19327

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit e7c0b1d)

Co-authored-by: Philipp Kahr <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Aug 12, 2020
…ne-2.0

* upstream/master: (39 commits)
  [ITs] Revert healthcheck for elasticsearchssl service to the previous behaviour (elastic#20558)
  [Heartbeat] Fix packaging (elastic#20566)
  [Heartbeat] Add Magefile to X-Pack (elastic#20549)
  [Packetbeat] Add "network" to event.category (elastic#20392)
  fix typo in docs (elastic#20541)
  Add service resource in k8s cluster role (elastic#20546)
  Update Golang version to 1.14.7 (elastic#20508)
  Add missing inputs to filebeat spec (elastic#20388)
  add warning log in aws and googlecloud module for API cost (elastic#20523)
  Fix fortinet.firewall.mem value to be interpreted as integer (elastic#19335)
  [CI] add more resilience (elastic#20505)
  [JJBB] fix credentials with a service account for golang-crossbuild (elastic#20537)
  [ITs] change healthcheck for elasticsearch (elastic#20514)
  [JJBB] fix credentials with a service account (elastic#20535)
  chore(ci): use build step for checking if is PR (elastic#20536)
  [CI] runbld project name (elastic#20466)
  Add panw.panos.endreason field (elastic#18705)
  [Filebeat] Fix PANW field spelling "veredict" to "verdict" (elastic#18808)
  Fix typo in netflow module docs (elastic#18992)
  Modified auditd ingest pipeline to handle node=hostname (elastic#19659)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
…#19335)

Fix fortinet.firewall.mem value to be interpreted as integer. Add convert processor for fortinet.firewall.mem to ingest pipeline.

Closes elastic#19327

Co-authored-by: Andrew Kroh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug Filebeat Filebeat release-note:breaking The content should be included as a breaking change v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fortinet.firewall.mem string value
5 participants