Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19268 to 7.x: Add support for cloudfoundry metrics collection using consumer v1 API #19372

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jun 24, 2020

Cherry-pick of PR #19268 to 7.x branch. Original message:

What does this PR do?

Continues with #19125 to add support to Cloud Foundry consumer v1 API in Metricbeat too.

version can be used to select if v1 or v2 version should be used.

Why is it important?

We already support the v2 API, but we saw that this API is not reliable enough (see #18202 and #18282).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Run metricbeat with the cloudfoundry input and check that it collects events. Try these combinations of the version option:
    • No version option (what would use v1)
    • version: v1.
    • version: v2.
    • For other values of version it should fail to start.

Related issues

…elastic#19268)

As previously done for the Filebeat input, add support for metrics collection
in the Metricbeat module using the consumer v1 API. It reuses the same
Doppler consumer used in Filebeat.

v2 API is still supported, and can be selected by adding `version: v2` to the
configuration, v1 is used by default as is in principle more reliable.

(cherry picked from commit 5645491)
@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jun 24, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19372 opened]

  • Start Time: 2020-06-24T17:06:54.759+0000

  • Duration: 73 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 6495
Skipped 1233
Total 7728

@jsoriano jsoriano merged commit 3987057 into elastic:7.x Jun 25, 2020
@jsoriano jsoriano deleted the backport_19268_7.x branch June 25, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants