-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Update crowdstrike module #20138
Merged
Merged
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4c341fd
Update crowdstrike module
665a80b
Add in blank UserIP test
a6d288c
Fix up conversion error with proper fail_on_error usage
30cf26d
Add timestamp processing for all timestamps
2151eea
Add event ingested timestamp
8b4b57a
Add Changelog entry
e361568
Merge branch 'master' into crowdstrike-fixes
cc8f478
Revert accidentally touching suricata pipeline
0c625ee
Fix up integration tests
1838a90
Merge branch 'master' of github.com:elastic/beats into crowdstrike-fixes
13c46c0
Update with new crowdstrike samples
7dfae0a
Only normalize process when we have info
ed257ee
Remove empty arguments from string split
ad59746
update changelog entry
4d8c1cf
Refactor to use built-in processors
0606fc4
clean up pipeline code
1589719
Fix linter errors and add related fields
3ca4e46
Run mage update in OSS folder to pick up updated fields docs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
"@timestamp": "2020-02-27T19:12:14.000Z", | ||
"crowdstrike.event.HostnameField": "hostnameofmachine", | ||
"crowdstrike.event.SessionId": "6020260b-0398-4d41-999d-5531b55522de", | ||
"crowdstrike.event.StartTimestamp": 1582830734, | ||
"crowdstrike.event.StartTimestamp": 1582830734000, | ||
"crowdstrike.event.UserName": "[email protected]", | ||
"crowdstrike.metadata.customerIDString": "8f69fe9e-b995-4204-95ad-44f9bcf75b6b", | ||
"crowdstrike.metadata.eventCreationTime": 1582830734000, | ||
|
@@ -35,7 +35,7 @@ | |
}, | ||
{ | ||
"@timestamp": "2020-02-27T19:12:52.000Z", | ||
"crowdstrike.event.EndTimestamp": 1582830772, | ||
"crowdstrike.event.EndTimestamp": 1582830772000, | ||
"crowdstrike.event.HostnameField": "hostnameofmachine", | ||
"crowdstrike.event.SessionId": "6020260b-0398-4d41-999d-5531b55522de", | ||
"crowdstrike.event.UserName": "[email protected]", | ||
|
@@ -94,7 +94,7 @@ | |
"crowdstrike.event.OperationName": "streamStarted", | ||
"crowdstrike.event.ServiceName": "Crowdstrike Streaming API", | ||
"crowdstrike.event.Success": true, | ||
"crowdstrike.event.UTCTimestamp": 1581542950, | ||
"crowdstrike.event.UTCTimestamp": 1581542950000, | ||
"crowdstrike.event.UserId": "api-client-id:1234567890abcdefghijklmnopqrstuvwxyz", | ||
"crowdstrike.event.UserIp": "10.10.0.8", | ||
"crowdstrike.metadata.customerIDString": "8f69fe9e-b995-4204-95ad-44f9bcf75b6b", | ||
|
@@ -219,7 +219,7 @@ | |
], | ||
"crowdstrike.event.OperationName": "update_group", | ||
"crowdstrike.event.ServiceName": "groups", | ||
"crowdstrike.event.UTCTimestamp": 1581546248, | ||
"crowdstrike.event.UTCTimestamp": 1581546248000, | ||
"crowdstrike.event.UserId": "[email protected]", | ||
"crowdstrike.event.UserIp": "192.168.6.13", | ||
"crowdstrike.metadata.customerIDString": "8f69fe9e-b995-4204-95ad-44f9bcf75b6b", | ||
|
@@ -521,7 +521,7 @@ | |
], | ||
"crowdstrike.event.OperationName": "detection_update", | ||
"crowdstrike.event.ServiceName": "detections", | ||
"crowdstrike.event.UTCTimestamp": 1581603262, | ||
"crowdstrike.event.UTCTimestamp": 1581603262000, | ||
"crowdstrike.event.UserId": "[email protected]", | ||
"crowdstrike.event.UserIp": "192.168.6.8", | ||
"crowdstrike.metadata.customerIDString": "8f69fe9e-b995-4204-95ad-44f9bcf75b6b", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we need this. In the convert it should be "fail_on_error: false", not "ignore_failure: true", then we don't need the dropIfEmpty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change, but are we ok with passing off an empty string in an
ip
field? You can take a look at the difference in the approach here: a6d288ccc: @tonymeehan