Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Switch performance metricset in MySQL module from Lightweight to native implementation #20184

Closed
wants to merge 2 commits into from
Closed

[Metricbeat] Switch performance metricset in MySQL module from Lightweight to native implementation #20184

wants to merge 2 commits into from

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Jul 23, 2020

What does this PR do?

Switch performance metricset from MySQL module from using a Lightweight implementation to use a native implementation

Why is it important?

There's a blocker bug in lightweight modules where host parsing is being executed twice producing errors when trying to interpret the address of the database. The workaround is to avoid parsing of the MySQL DSN but then, credentials are exposed on the events.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@sayden sayden added bug needs_backport PR is waiting to be backported to other branches. Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 labels Jul 23, 2020
@sayden sayden self-assigned this Jul 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 23, 2020
@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Jul 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 23, 2020 •
edited by jenkins-beats-ci bot
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20184 updated]

  • Start Time: 2020-07-23T10:42:01.075+0000

  • Duration: 15 min 14 sec

Steps errors

Expand to view the steps failures

  • Name: Make check

    • Description: make check

    • Duration: 7 min 37 sec

    • Start Time: 2020-07-23T10:50:07.978+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-07-23T10:56:52.522Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:52.523Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-07-23T10:56:52.524Z] Stage "Packetbeat OSS" skipped due to earlier failure(s)
[2020-07-23T10:56:52.525Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:52.526Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:52.527Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:52.528Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:52.529Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-23T10:56:53.060Z] Failed in branch Elastic Agent x-pack
[2020-07-23T10:56:53.061Z] Failed in branch Elastic Agent x-pack Windows
[2020-07-23T10:56:53.070Z] Failed in branch Elastic Agent Mac OS X
[2020-07-23T10:56:53.070Z] Failed in branch Filebeat oss
[2020-07-23T10:56:53.071Z] Failed in branch Filebeat x-pack
[2020-07-23T10:56:53.072Z] Failed in branch Filebeat Mac OS X
[2020-07-23T10:56:53.072Z] Failed in branch Filebeat x-pack Mac OS X
[2020-07-23T10:56:53.073Z] Failed in branch Filebeat Windows
[2020-07-23T10:56:53.073Z] Failed in branch Filebeat x-pack Windows
[2020-07-23T10:56:53.074Z] Failed in branch Auditbeat oss Linux
[2020-07-23T10:56:53.074Z] Failed in branch Auditbeat crosscompile
[2020-07-23T10:56:53.075Z] Failed in branch Auditbeat oss Mac OS X
[2020-07-23T10:56:53.075Z] Failed in branch Auditbeat oss Windows
[2020-07-23T10:56:53.076Z] Failed in branch Auditbeat x-pack
[2020-07-23T10:56:53.076Z] Failed in branch Auditbeat x-pack Mac OS X
[2020-07-23T10:56:53.077Z] Failed in branch Auditbeat x-pack Windows
[2020-07-23T10:56:53.077Z] Failed in branch Libbeat x-pack
[2020-07-23T10:56:53.078Z] Failed in branch Metricbeat OSS Unit tests
[2020-07-23T10:56:53.079Z] Failed in branch Metricbeat OSS Go Integration tests
[2020-07-23T10:56:53.079Z] Failed in branch Metricbeat OSS Python Integration tests
[2020-07-23T10:56:53.080Z] Failed in branch Metricbeat crosscompile
[2020-07-23T10:56:53.080Z] Failed in branch Metricbeat Mac OS X
[2020-07-23T10:56:53.081Z] Failed in branch Metricbeat x-pack Mac OS X
[2020-07-23T10:56:53.081Z] Failed in branch Metricbeat Windows
[2020-07-23T10:56:53.082Z] Failed in branch Metricbeat x-pack Windows
[2020-07-23T10:56:53.082Z] Failed in branch Winlogbeat Windows x-pack
[2020-07-23T10:56:53.083Z] Failed in branch Kubernetes
[2020-07-23T10:56:53.337Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:53.338Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:53.339Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-07-23T10:56:53.340Z] Stage "Packetbeat OSS" skipped due to earlier failure(s)
[2020-07-23T10:56:53.341Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:53.342Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:53.343Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-23T10:56:53.378Z] Failed in branch dockerlogbeat
[2020-07-23T10:56:53.379Z] Failed in branch Journalbeat
[2020-07-23T10:56:53.590Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:53.591Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:53.592Z] Stage "Packetbeat OSS" skipped due to earlier failure(s)
[2020-07-23T10:56:53.593Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-23T10:56:53.594Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-23T10:56:53.630Z] Failed in branch Metricbeat x-pack
[2020-07-23T10:56:53.631Z] Failed in branch Winlogbeat
[2020-07-23T10:56:53.838Z] Failed in branch Heartbeat
[2020-07-23T10:56:53.838Z] Failed in branch Libbeat
[2020-07-23T10:56:53.839Z] Failed in branch Packetbeat OSS
[2020-07-23T10:56:53.839Z] Failed in branch Functionbeat
[2020-07-23T10:56:53.840Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-23T10:56:53.912Z] Failed in branch Generators
[2020-07-23T10:56:54.034Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20184/src/github.com/elastic/beats
[2020-07-23T10:56:54.337Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-23T10:56:54.349Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20184/src/github.com/elastic/beats/Lint
[2020-07-23T10:56:54.720Z] + cat
[2020-07-23T10:56:54.720Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-23T10:56:54.720Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-23T10:57:01.315Z] runbld>>> runbld started
[2020-07-23T10:57:01.315Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-23T10:57:02.702Z] runbld>>> The following profiles matched the job 'Beats/beats/PR-20184' in order of occurrence in the config (last value wins).
[2020-07-23T10:57:04.090Z] runbld>>> Debug logging enabled.
[2020-07-23T10:57:04.090Z] runbld>>> Storing result
[2020-07-23T10:57:04.090Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-23T10:57:04.090Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200723105703-31001F7D
[2020-07-23T10:57:04.090Z] runbld>>> Adding system facts.
[2020-07-23T10:57:05.052Z] runbld>>> Adding vcs info for the latest commit:  3134842882d3a9688fd3c0968e601e035881f640
[2020-07-23T10:57:05.052Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-23T10:57:05.052Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-23T10:57:05.052Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-23T10:57:05.052Z] Processing JUnit reports with runbld...
[2020-07-23T10:57:05.624Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-23T10:57:05.624Z] runbld>>> DURATION: 19ms
[2020-07-23T10:57:05.624Z] runbld>>> STDOUT: 40 bytes
[2020-07-23T10:57:05.624Z] runbld>>> STDERR: 49 bytes
[2020-07-23T10:57:05.624Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-23T10:57:05.624Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-20184/src/github.com/elastic/beats
[2020-07-23T10:57:06.567Z] runbld>>> Storing build metadata: 
[2020-07-23T10:57:06.567Z] runbld>>> Adding test report.
[2020-07-23T10:57:06.567Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-20184/src/github.com/elastic/beats
[2020-07-23T10:57:07.139Z] runbld>>> Found 0 test output files
[2020-07-23T10:57:07.139Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 0 Skipped: 0
[2020-07-23T10:57:07.400Z] runbld>>> Storing result
[2020-07-23T10:57:07.660Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-23T10:57:07.661Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200723105703-31001F7D
[2020-07-23T10:57:07.661Z] runbld>>> Email notification disabled by environment variable.
[2020-07-23T10:57:07.661Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-23T10:57:14.424Z] Running on worker-395930 in /var/lib/jenkins/workspace/Beats_beats_PR-20184
[2020-07-23T10:57:14.519Z] [INFO] getVaultSecret: Getting secrets
[2020-07-23T10:57:14.606Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-23T10:57:16.697Z] + chmod 755 generate-build-data.sh
[2020-07-23T10:57:16.697Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20184/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20184/runs/2 FAILURE 914225
[2020-07-23T10:57:16.697Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20184/runs/2/steps/?limit=10000 -o steps-info.json
[2020-07-23T10:57:17.397Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20184/runs/2/tests/?status=FAILED -o tests-errors.json
[2020-07-23T10:57:18.097Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20184/runs/2/log/ -o pipeline-log.txt

@jsoriano
Copy link
Member

After #20149 only f318b64 would be needed.

@sayden sayden closed this Jul 23, 2020
@sayden sayden deleted the bufix/mb/mysql/switch-performance-to-native branch August 25, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sayden sayden

Labels
bug needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayden @elasticmachine @jsoriano @andresrc