Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21202 to 7.x: Stop running auditbeat container as root by default #21291

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Sep 24, 2020

Cherry-pick of PR #21202 to 7.x branch. Original message:

What does this PR do?

Stop running Auditbeat container as root by default. After this change, when user root is required it will need to be explicitly set on runtime. This is already done in Kubernetes manifests and some other examples in the documentation, so change is probably not so breaking.
Also USER root is usually not enough to be fully privileged, so some customization was always expected when running Auditbeat on docker.

Why is it important?

Using USER root in docker images is not a very good practice, and is not allowed in some certification processes (see #20996).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Run Auditbeat on docker using a configuration that requires root privileges.

Related issues

Stop running Auditbeat container as root by default. After this change,
when user root is required it will need to be explicitly set on runtime.
This is already done in Kubernetes manifests and some other examples
in the documentation, so change is probably not so breaking.
Also `USER root` is usually not enough to be fully privileged, so some
customization was always expected when running Auditbeat on docker.

(cherry picked from commit 6bd7090)
@jsoriano jsoriano requested a review from a team as a code owner September 24, 2020 11:48
@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team Team:SIEM labels Sep 24, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 24, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21291 opened]

  • Start Time: 2020-09-24T11:49:47.338+0000

  • Duration: 68 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 595
Skipped 81
Total 676

@jsoriano jsoriano merged commit 0c2f218 into elastic:7.x Sep 28, 2020
@jsoriano jsoriano deleted the backport_21202_7.x branch September 28, 2020 11:14
@zube zube bot removed the [zube]: Done label Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants